Re: [PATCH 1/2] rust: pin-init: fix broken rust doc link

["Benno Lossin" <lossin@kernel.org>]

On Thu Oct 16, 2025 at 11:24 PM CEST, Miguel Ojeda wrote:
> On Thu, Oct 16, 2025 at 11:17 PM Benno Lossin <lossin@kernel.org> wrote:
>>
>> Rust 1.92.0 warns when building the documentation that [`PinnedDrop`] is
>> an invalid reference. This is correct and it's weird that it didn't warn
>> before, so fix the link.
>
> It is because it is hidden -- I have patches to fix this (it is not
> just in pin-init but elsewhere too), but I am waiting for confirmation
> on whether this is actually intentional behavior:
>
>     https://github.com/rust-lang/rust/pull/147153#issuecomment-3395484636
>
> From the early reply I got, it seems it is not, so it may be that it is "fixed".
>
> Personally, I think it is useful, so I hope they keep it, even if as a
> new opt-in option or similar.
>
> Of course, we can land this patch since it does not matter either way,
> but please add a note with the above in the commit message if you land
> it.

Thanks a lot for the added context! I will add it when applying. The
`__pinned_drop!` macro will be gone with the syn patches this cycle, so
in this case, we don't care what the resolution will be.

---
Cheers,
Benno