Re: [PATCH] rust: acpi: replace `core::mem::zeroed` with `pin_init::zeroed`

Kunwu Chan
2025-10-22T06:02:43Z

On 10/20/25 11:12, Siyuan Huang wrote:
> All types in `bindings` implement `Zeroable` if they can, so use
> `pin_init::zeroed` instead of relying on `unsafe` code.
>
> If this ends up not compiling in the future, something in bindgen or on
> the C side changed and is most likely incorrect.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1189
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Signed-off-by: Siyuan Huang <huangsiyuan@kylinos.cn>
> ---
> rust/kernel/acpi.rs | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/rust/kernel/acpi.rs b/rust/kernel/acpi.rs
> index 7ae317368b00..f9488be9249c 100644
> --- a/rust/kernel/acpi.rs
> +++ b/rust/kernel/acpi.rs
> @@ -42,9 +42,7 @@ pub const fn new(id: &'static CStr) -> Self {
> "ID exceeds 16 bytes"
> );
> let src = id.as_bytes_with_nul();
> - // Replace with `bindings::acpi_device_id::default()` once stabilized for `const`.
> - // SAFETY: FFI type is valid to be zero-initialized.
> - let mut acpi: bindings::acpi_device_id = unsafe { core::mem::zeroed() };
> + let mut acpi: bindings::acpi_device_id = pin_init::zeroed();
> let mut i = 0;
> while i < src.len() {
> acpi.id[i] = src[i];

Reviewed-by: Kunwu Chan <chentao@kylinos.cn>

--
Thanks,
Kunwu Chan.