From: "Bhavik Sachdev" <b.sachdev1904@gmail.com>
To: "Christian Brauner" <brauner@kernel.org>
Cc: "Alexander Viro" <viro@zeniv.linux.org.uk>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Aleksa Sarai" <cyphar@cyphar.com>,
"Pavel Tikhomirov" <ptikhomirov@virtuozzo.com>,
"Jan Kara" <jack@suse.cz>, "John Garry" <john.g.garry@oracle.com>,
"Arnaldo Carvalho de Melo" <acme@redhat.com>,
"Darrick J . Wong" <djwong@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Andrei Vagin" <avagin@gmail.com>,
"Alexander Mikhalitsyn" <alexander@mihalicyn.com>
Subject: Re: [PATCH v2 1/1] statmount: accept fd as a parameter
Date: Wed, 22 Oct 2025 21:09:42 +0530 [thread overview]
Message-ID: <DDOYPQ2FG2ZF.2RO4YIQ0TRKJA@gmail.com> (raw)
In-Reply-To: <20251021-blaumeise-verfassen-b8361569b6aa@brauner>
On Tue Oct 21, 2025 at 5:41 PM IST, Christian Brauner wrote:
> Hm, do you really need a new field? You could just use the @spare
> parameter in struct mnt_id_req. It's currently validated of not being
> allowed to be non-zero in copy_mnt_id_req() which is used by both
> statmount() and listmount().
>
> I think you could just reuse it for this purpose in statmount(). And
> then maybe the flag should be STATMOUNT_BY_FD?
>
We made a new field because we thought @spare is already being used (or
will have a future use?). grab_requested_mnt_ns uses @spare as a mount
namespace fd [1], but we also only allow @spare to be 0, so I don't
really understand whats happening here, is this functionality disabled?
> Otherwise I think this could work.
>
Thanks, Christian! I will send a new patch with all your requested
changes.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7b9d14af8777ac439bbfa9ac73a12a6d85289e7e
next prev parent reply other threads:[~2025-10-22 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-11 12:46 [PATCH v2 0/1] statmount: mountinfo for "unmounted" mounts Bhavik Sachdev
2025-10-11 12:46 ` [PATCH v2 1/1] statmount: accept fd as a parameter Bhavik Sachdev
2025-10-21 12:11 ` Christian Brauner
2025-10-22 15:39 ` Bhavik Sachdev [this message]
2025-10-22 16:32 ` Miklos Szeredi
2025-10-22 18:12 ` Bhavik Sachdev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDOYPQ2FG2ZF.2RO4YIQ0TRKJA@gmail.com \
--to=b.sachdev1904@gmail.com \
--cc=acme@redhat.com \
--cc=alexander@mihalicyn.com \
--cc=avagin@gmail.com \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=john.g.garry@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox