Re: [PATCH] arm64: dts: rockchip: Harmonize regulator formatting for Pine64 rk3566 devices

["Diederik de Haas" <diederik@cknow-tech.com>]

Hi Heiko (and Dragan and Jonas),

On Mon Oct 27, 2025 at 5:46 PM CET, Heiko Stuebner wrote:
> Am Sonntag, 26. Oktober 2025, 18:44:42 Mitteleuropäische Normalzeit schrieb Diederik de Haas:
>> On Sun Oct 26, 2025 at 4:37 PM CET, Diederik de Haas wrote:
>> > The regulator node properties in Pine64 rk3566 devices were formatted
>> > rather inconsistently. To name a few:
>> >
>> > So harmonize the formatting by making all properties sorted
>> > alphabetically/naturally. And harmonize the formatting of the
>> > 'state-mem' nodes so they all have a preceding blank line. While at it,
>> > also fix 2 incorrectly indented nodes.
>
> Originally, I always liked regulator-name to be on top, identifying
> the regulator, similar to how compatible works.

That makes a lot of sense to me and I had actually thought about doing
that. But I didn't have a justification for it, while referring to the
DTS style guide is a justification. My annoyance was with the
inconsistency, so consistently putting 'name' on top would be fine too.

> The other issue with moving stuff around is, that it makes it harder
> to follow git history, because git blame then reports the sort-commit.

Then it's not worth it ...

> I guess it is ok for individual files, someone does take care of,
> like Diederik for the Pinetab, but please don't start resorting all the
> existing devicetrees :-) .

... and I'll file it under PEBKAC.

Cheers,
  Diederik