From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "John Hubbard" <jhubbard@nvidia.com>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Edwin Peer" <epeer@nvidia.com>, "Zhi Wang" <zhiw@nvidia.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Nouveau <nouveau-bounces@lists.freedesktop.org>
Subject: Re: [PATCH v2 2/2] gpu: nova-core: add boot42 support for next-gen GPUs
Date: Tue, 28 Oct 2025 20:42:44 +0900 [thread overview]
Message-ID: <DDTXFK7JE59S.19TLPYTWTFHSU@nvidia.com> (raw)
In-Reply-To: <20251028023937.1313108-3-jhubbard@nvidia.com>
On Tue Oct 28, 2025 at 11:39 AM JST, John Hubbard wrote:
<snip>
> + // Now that we know it is something more recent than NV04, use boot42 if we
> + // previously determined that boot42 was both valid and relevant, and boot0
> + // otherwise.
> + let (chipset, major_revision, minor_revision) = if let Some(boot42) = boot42 {
> + (
> + boot42.chipset()?,
> + boot42.major_revision(),
> + boot42.minor_revision(),
> + )
> + } else {
> + // Current/older GPU: use BOOT0
> + (
> + boot0.chipset()?,
> + boot0.major_revision(),
> + boot0.minor_revision(),
> + )
> + };
> +
> Ok(Self {
> - chipset: boot0.chipset()?,
> - major_revision: boot0.major_revision(),
> - minor_revision: boot0.minor_revision(),
> + chipset,
> + major_revision,
> + minor_revision,
> })
Can we implement `TryFrom<NV_PMC_BOOT_0> for Spec` (and same for
`NV_PMC_BOOT_42`)? That way this code can become:
boot42.map(Spec::try_from).unwrap_or_else(|| Spec::try_from(boot0))
(untested ; but hopefully not too incorrect)
next prev parent reply other threads:[~2025-10-28 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 2:39 [PATCH v2 0/2] gpu: nova: add boot42 support for next-gen GPUs John Hubbard
2025-10-28 2:39 ` [PATCH v2 1/2] gpu: nova-core: merge the Revision type into the Spec type John Hubbard
2025-10-28 12:25 ` Danilo Krummrich
2025-10-28 17:25 ` John Hubbard
2025-10-28 2:39 ` [PATCH v2 2/2] gpu: nova-core: add boot42 support for next-gen GPUs John Hubbard
2025-10-28 11:42 ` Alexandre Courbot [this message]
2025-10-28 17:22 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDTXFK7JE59S.19TLPYTWTFHSU@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau-bounces@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox