From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1DF92AE99;
	Tue,  4 Nov 2025 14:16:40 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1762265801; cv=none; b=UrguBIM881ZFjIymK3QF2a8JCWSYn7NfHDHf7RAIz5Qbxp++Tbl/LvyD+BAkVwzBSN78zw18U7pHaFA9u0QotHzoiMW1U7mqukN9JQezhQuhYYt+J1WcCFg6YjG3kozpXfEV/kGZpsZtwh2QpnuHhfQpgezB4liHesHIfXC+6EI=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1762265801; c=relaxed/simple;
	bh=LLH6LMsUoW83OgwHn4Eb7C7d3t9QxE00ZT++B0K2C6c=;
	h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From:
	 References:In-Reply-To; b=hGfAN88iBgDhUpOpWH69Pn06I3CFRjuZhZGKgLqF9kNgY/WNSDXitXDW+luTrwZh7amsqfWGhSjX+BfX96YiAoNAwy/eM5l5l1+a5suIxcPyim0wZz54x3DD82cUmi7+SjwkqycgZab/aTdMlHv8FHvrgmge/4hLmfMSOIrxmAE=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Fx4ECpUY; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Fx4ECpUY"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CDDFC4CEF7;
	Tue,  4 Nov 2025 14:16:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1762265800;
	bh=LLH6LMsUoW83OgwHn4Eb7C7d3t9QxE00ZT++B0K2C6c=;
	h=Date:Subject:Cc:To:From:References:In-Reply-To:From;
	b=Fx4ECpUYVm71v3CRagzLhvmjDKBOecwkunXFsn2pQTuEEoSEf+K4kyWXyGwQKQwf8
	 xArw3A1/tF9hV4GZam7wbH8k3PX1vNM96gFdbw47GeS0UJovsoZZUsM6Y8x4ms9zTq
	 fuo158aeAKMP+rxd7q8AkO1/UOM8U9eilv2FtTLJSKljszVEJ9ww18shEZt4db/lrF
	 uQlYIRUDwb1AN3jeclvRrlrHQ6NmqL6zJgOwBnFN3ZlmQn/28lDxUXlZ9PISPpVcAK
	 LNKyh/6UKufTc5cP2Snm6VbXvGgiYy1pGsWSuyMc7IkoEnqbv0t7nCAxBQL0oG1+dm
	 p6sa+O7dnKqbA==
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 04 Nov 2025 15:16:33 +0100
Message-Id: <DDZZ356YT8HY.S8G709WO4MD3@kernel.org>
Subject: Re: [PATCH] firmware_loader: make RUST_FW_LOADER_ABSTRACTIONS
 select FW_LOADER
Cc: "Luis Chamberlain" <mcgrof@kernel.org>, "Russ Weight"
 <russ.weight@linux.dev>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
 "Rafael J. Wysocki" <rafael@kernel.org>, "Alice Ryhl"
 <aliceryhl@google.com>, "David Airlie" <airlied@gmail.com>, "Simona Vetter"
 <simona@ffwll.ch>, "Andrew Lunn" <andrew@lunn.ch>, "Heiner Kallweit"
 <hkallweit1@gmail.com>, "Russell King" <linux@armlinux.org.uk>, "David S.
 Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>, "Jakub
 Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Miguel
 Ojeda" <ojeda@kernel.org>, "Alex Gaynor" <alex.gaynor@gmail.com>, "Boqun
 Feng" <boqun.feng@gmail.com>, "Gary Guo" <gary@garyguo.net>,
 =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>, "Benno Lossin"
 <lossin@kernel.org>, "Andreas Hindborg" <a.hindborg@kernel.org>, "Trevor
 Gross" <tmgross@umich.edu>, <linux-kernel@vger.kernel.org>,
 <nouveau@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>,
 <netdev@vger.kernel.org>, <rust-for-linux@vger.kernel.org>
To: "Alexandre Courbot" <acourbot@nvidia.com>
From: "Danilo Krummrich" <dakr@kernel.org>
References: <20251104-b4-select-rust-fw-v1-1-afea175dba22@nvidia.com>
In-Reply-To: <20251104-b4-select-rust-fw-v1-1-afea175dba22@nvidia.com>

On Tue Nov 4, 2025 at 3:04 PM CET, Alexandre Courbot wrote:
> I have noticed that build will fail when doing the following:
>
> - Start with the x86 defconfig,
> - Using nconfig, enable `CONFIG_RUST` and `CONFIG_DRM_NOVA`,
> - Start building.
>
> The problem is that `CONFIG_RUST_FW_LOADER_ABSTRACTIONS` remains
> unselected, despite it being a dependency of `CONFIG_NOVA_CORE`. This
> seems to happen because `CONFIG_DRM_NOVA` selects `CONFIG_NOVA_CORE`.
>
> Fix this by making `CONFIG_RUST_FW_LOADER_ABSTRACTIONS` select
> `CONFIG_FW_LOADER`, and by transition make all users of
> `CONFIG_RUST_FW_LOADER_ABSTRACTIONS` (so far, nova-core and net/phy)
> select it as well.
>
> `CONFIG_FW_LOADER` is more often selected than depended on, so this
> seems to make sense generally speaking.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> I am not 100% percent confident that this is the proper fix, but the
> problem is undeniable. :) I guess the alternative would be to make nova-d=
rm
> depend on nova-core instead of selecting it, but I suspect that the
> `select` behavior is correct in this case - after all, firmware loading
> does not make sense without any user.

This patch is the correct approach.

However, I think this should be three separate patches, so they can go thro=
ugh
different trees.

Also, please add a Fixes: tag.