From: "Danilo Krummrich" <dakr@kernel.org>
To: "Christian Brauner" <brauner@kernel.org>
Cc: <gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<ojeda@kernel.org>, <alex.gaynor@gmail.com>,
<boqun.feng@gmail.com>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
<a.hindborg@kernel.org>, <aliceryhl@google.com>,
<tmgross@umich.edu>, <viro@zeniv.linux.org.uk>, <jack@suse.cz>,
<arnd@arndb.de>, <rust-for-linux@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>
Subject: Re: [PATCH 1/3] rust: fs: add a new type for file::Offset
Date: Wed, 05 Nov 2025 12:19:17 +0100 [thread overview]
Message-ID: <DE0PXYNG8O8W.19MUQ9TGA6C04@kernel.org> (raw)
In-Reply-To: <20251105-begibt-gipfel-cf2718233888@brauner>
On Wed Nov 5, 2025 at 11:59 AM CET, Christian Brauner wrote:
> On Wed, Nov 05, 2025 at 01:22:48AM +0100, Danilo Krummrich wrote:
>> Replace the existing file::Offset type alias with a new type.
>>
>> Compared to a type alias, a new type allows for more fine grained
>> control over the operations that (semantically) make sense for a
>> specific type.
>>
>> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
>> Cc: Christian Brauner <brauner@kernel.org>
>> Cc: Jan Kara <jack@suse.cz>
>> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
>> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
>> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
>> Link: https://github.com/Rust-for-Linux/linux/issues/1198
>> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
>> ---
>
> What's the base for this?
> If it's stuff that belongs to fs/ I'd prefer if it always uses a stable
> -rc* version as base where possible.
Please see [1]; the base is [2] from the driver-core tree.
[1] https://lore.kernel.org/lkml/DE0C1KA14PDQ.Q2CJDDTQPWOK@kernel.org/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git/tree/?id=1bf5b90cd2f984e5d6ff6fd30d5d85f9f579b6f0
next prev parent reply other threads:[~2025-11-05 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 0:22 [PATCH 1/3] rust: fs: add a new type for file::Offset Danilo Krummrich
2025-11-05 0:22 ` [PATCH 2/3] rust fs: kiocb: take advantage from file::Offset Danilo Krummrich
2025-11-05 10:19 ` Alice Ryhl
2025-11-05 0:22 ` [PATCH 3/3] rust: iov: " Danilo Krummrich
2025-11-05 10:21 ` Alice Ryhl
2025-11-05 10:59 ` [PATCH 1/3] rust: fs: add a new type for file::Offset Christian Brauner
2025-11-05 11:19 ` Danilo Krummrich [this message]
2025-11-05 11:39 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE0PXYNG8O8W.19MUQ9TGA6C04@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=arnd@arndb.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brauner@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox