From: "Diederik de Haas" <diederik@cknow-tech.com>
To: "Heiko Stuebner" <heiko@sntech.de>
Cc: <mturquette@baylibre.com>, <sboyd@kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-rockchip@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <michael.riesch@collabora.com>
Subject: Re: [PATCH 1/3] dt-bindings: clock: rk3568: Add SCMI clock ids
Date: Wed, 05 Nov 2025 14:08:59 +0100 [thread overview]
Message-ID: <DE0S9YBDI0NK.2892TZHYSQLFM@cknow-tech.com> (raw)
In-Reply-To: <20251103234926.416137-2-heiko@sntech.de>
On Tue Nov 4, 2025 at 12:49 AM CET, Heiko Stuebner wrote:
> The Trusted Firmware on RK3568 exposes 3 clocks via the SCMI clock
> interface. Add descriptive IDs for them.
>
> The clock ids are used in both the older vendor-binary TF-A, as well
> as the recently merged upstream SCMI clock implementation.
>
> Link: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/31265
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> include/dt-bindings/clock/rk3568-cru.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/dt-bindings/clock/rk3568-cru.h b/include/dt-bindings/clock/rk3568-cru.h
> index f01f0e9ce8f1..1e0aef8a645d 100644
> --- a/include/dt-bindings/clock/rk3568-cru.h
> +++ b/include/dt-bindings/clock/rk3568-cru.h
> @@ -483,6 +483,12 @@
>
> #define PCLK_CORE_PVTM 450
>
> +/* scmi-clocks indices */
> +
> +#define SCMI_CLK_CPU 0
> +#define SCMI_CLK_GPU 1
> +#define SCMI_CLK_NPU 2
> +
This corresponds with the id's in ``clock_table`` in TF-A's
``plat/rockchip/rk3568/drivers/scmi/rk3568_clk.c`` file, so
Reviewed-by: Diederik de Haas <diederik@cknow-tech.com>
> /* pmu soft-reset indices */
> /* pmucru_softrst_con0 */
> #define SRST_P_PDPMU_NIU 0
next prev parent reply other threads:[~2025-11-05 13:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 23:49 [PATCH 0/3] SCMI clocks on RK356x Heiko Stuebner
2025-11-03 23:49 ` [PATCH 1/3] dt-bindings: clock: rk3568: Add SCMI clock ids Heiko Stuebner
2025-11-04 17:25 ` Conor Dooley
2025-11-05 13:08 ` Diederik de Haas [this message]
2025-11-03 23:49 ` [PATCH 2/3] arm64: dts: rockchip: use SCMI clock id for cpu clock on rk356x Heiko Stuebner
2025-11-05 13:16 ` Diederik de Haas
2025-11-05 23:43 ` Heiko Stuebner
2025-11-03 23:49 ` [PATCH 3/3] arm64: dts: rockchip: add missing clocks for cpu cores " Heiko Stuebner
2025-11-05 13:18 ` Diederik de Haas
2025-11-05 23:26 ` [PATCH 0/3] SCMI clocks on RK356x Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE0S9YBDI0NK.2892TZHYSQLFM@cknow-tech.com \
--to=diederik@cknow-tech.com \
--cc=conor+dt@kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@collabora.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox