Re: [PATCH v2 0/7] Add generic PHY driver used by MACB/GEM on EyeQ5

["Théo Lebrun" <theo.lebrun@bootlin.com>]

On Thu Nov 6, 2025 at 11:51 AM CET, Philipp Zabel wrote:
> On Sa, 2025-11-01 at 09:53 +0100, Théo Lebrun wrote:
>> About merging, it'll probably be complex. I see no build dependencies,
>> but the board will be in an odd state if only some patches are applied.
>> Some dev_warn() at boot and dev->of_node refcounting issues at unload.
>> 
>>  - [PATCH 1/7] dt-bindings: soc: mobileye: OLB is an Ethernet PHY provider on EyeQ5
>>    We touch dt-bindings because OLB becomes a PHY provider.
>>    => linux-mips (?)
>> 
>>  - [PATCH 2/7] phy: Add driver for EyeQ5 Ethernet PHY wrapper
>>    We add the generic PHY driver in drivers/phy/phy-eyeq5-eth.c with the
>>    usual Kconfig, Makefile and MAINTAINERS changes.
>>    => linux-phy (?)
>> 
>>  - [PATCH 6/7] MIPS: mobileye: eyeq5: add two Cadence GEM Ethernet controllers
>>    [PATCH 7/7] MIPS: mobileye: eyeq5-epm: add two Cadence GEM Ethernet PHYs
>>    DTS patches to add both the #phy-cells of OLB and the MACB instances.
>>    => linux-mips
>> 
>>  - [PATCH 4/7] clk: eyeq: add EyeQ5 children auxiliary device for generic PHYs
>>    We must update clk-eyeq because it instantiates a new auxdev.
>>    => linux-clk
>> 
>>  - [PATCH 3/7] clk: eyeq: use the auxiliary device creation helper
>>    [PATCH 5/7] reset: eyeq: drop device_set_of_node_from_dev() done by parent
>>    With the dev->of_node assignement, we must also correct reset-eyeq.
>>    => separate them into linux-clk and linux-reset?
>
> Since 3 and 4 should go via clk, and 5 has a dependency on 3, I would
> suggest merging them all together.

Thanks for the feedback Philipp, and the review on [5/7]. Getting it
merged in linux-clk will ease the process and avoid breakage. Updated
summary:

 - [PATCH 1/7] dt-bindings: soc: mobileye: OLB is an Ethernet PHY provider on EyeQ5
   [PATCH 6/7] MIPS: mobileye: eyeq5: add two Cadence GEM Ethernet controllers
   [PATCH 7/7] MIPS: mobileye: eyeq5-epm: add two Cadence GEM Ethernet PHYs
   => linux-mips

 - [PATCH 2/7] phy: Add driver for EyeQ5 Ethernet PHY wrapper
   => linux-phy

 - [PATCH 3/7] clk: eyeq: use the auxiliary device creation helper
   [PATCH 4/7] clk: eyeq: add EyeQ5 children auxiliary device for generic PHYs
   [PATCH 5/7] reset: eyeq: drop device_set_of_node_from_dev() done by parent
   => linux-clk

I might send V3 soon, with your trailers appended.

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com