[PATCH] ASoC: dapm-graph: Handle sourd card with space in name

[PATCH] ASoC: dapm-graph: Handle sourd card with space in name

[Yiwei Lin]

When the name of the sound card has a space between, the
script will fail to output the dot file. Consider the
case to generate it correctly.

Signed-off-by: Yiwei Lin <s921975628@gmail.com>
---
 tools/sound/dapm-graph | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/sound/dapm-graph b/tools/sound/dapm-graph
index b6196ee50..22993317d 100755
--- a/tools/sound/dapm-graph
+++ b/tools/sound/dapm-graph
@@ -174,7 +174,7 @@ process_dapm_component()
 
 	# Extract directory name into component name:
 	#   "./cs42l51.0-004a/dapm" -> "cs42l51.0-004a"
-	c_name="$(basename $(dirname "${c_dir}"))"
+	c_name="$(basename "$(dirname "${c_dir}")")"
     fi
 
     dbg_echo " * Component: ${c_name}"
@@ -201,7 +201,7 @@ process_dapm_component()
     >"${links_file}"
 
     # Iterate over widgets in the component dir
-    for w_file in ${c_dir}/*; do
+    for w_file in "${c_dir}"/*; do
 	process_dapm_widget "${tmp_dir}" "${c_name}" "${w_file}"
     done
 
-- 
2.34.1

Re: [PATCH] ASoC: dapm-graph: Handle sourd card with space in name

[Luca Ceresoli]

Hello Yiwei,

On Thu Nov 6, 2025 at 5:58 PM CET, Yiwei Lin wrote:
> When the name of the sound card has a space between, the
> script will fail to output the dot file. Consider the
> case to generate it correctly.
>
> Signed-off-by: Yiwei Lin <s921975628@gmail.com>

Thanks for your patch!

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] ASoC: dapm-graph: Handle sourd card with space in name

[Markus Elfring]

> When the name of the sound card has a space between, the
> script will fail to output the dot file. Consider the
> case to generate it correctly.

* You may occasionally put more than 56 characters into text lines
  of such a change description.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc4#n658

* I hope that a typo will be avoided for the summary phrase finally.


Regards,
Markus

Re: [PATCH] ASoC: dapm-graph: Handle sourd card with space in name

[Yiwei Lin]

On 11/7/2025 7:01 PM, Markus Elfring wrote:
>> When the name of the sound card has a space between, the
>> script will fail to output the dot file. Consider the
>> case to generate it correctly.
> * You may occasionally put more than 56 characters into text lines
>    of such a change description.
>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc4#n658
>
> * I hope that a typo will be avoided for the summary phrase finally.
Sorry for making such a mistake... I'll send another patch to fix 
regarding these error.
>
> Regards,
> Markus