From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93A372BDC0C; Wed, 19 Nov 2025 15:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763565241; cv=none; b=TKFfagY3vbCX1m4TdAEYgdB1jZLdojbcidh/nB6Ysx1b5SjENVi6L/YqusQmLzz4tvdBnNC5ArinqH/W2VsfTTulFIyTDpQrV0kOltCXWGCyew47gOiTBqypMDqfxaF/zwVwcMJMnhoY+dsXTNkzVLPA7JLVFAZvbBR3d4PyBi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763565241; c=relaxed/simple; bh=jTVZWb1z3cijgYgnTd2OTnTD3iYb79u3u3LIuyPG89o=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=tDE5T26lGQR5BT1uhkVYVK4i+jDMKGztuLNt98d/uyGyB1e3uSAPFqXZmXz0lCymSVII1BA4TCHTj2HEV9SOQh7lbQccR4jwp/vrW7MkIdjDBs9ASJSKAV0s09cwZQoUTNxAkSNj6Lh1H+YCgCsLQNdzbZYb/pHjFPIEfTukHgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=m7vF4ll1; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="m7vF4ll1" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 8CC83C1118A; Wed, 19 Nov 2025 15:13:33 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B484260699; Wed, 19 Nov 2025 15:13:55 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8CF7910371A8A; Wed, 19 Nov 2025 16:13:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763565233; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=7NujdOdzUvG8wdCZQfUnNhZngIGWDfpoPw7syCRBlyU=; b=m7vF4ll1ceXLHQ7SOaiZpgd4CxFPgYohzfJ0NlZ0aTzSJaXD9VTyQ0b6Nca2vIQ/wrWegN X7lT/+WK9S++6avBgiOXY9NP7+MI1jjWHWI7RBsLQX6wfWReUJ54QYX3K53QOZ6/y8dBoc rwTJVJ7c+G9WaXQ8N7tTqpG6uDWPHNfn1xUUQJ6LI4Em7jpXR+JjigURq762sngel+VEcW YeNbzw3ktmsl5OOmcChfp5qJ6/9qH6bPrQk2TgiRq9mOSsRfXE2q6j3dzq+QEA4YtrRHS0 cD5J70cFAFYr33yZY126C/B2axcVbx4hl6oArAJtX+b6b2pfPjSYBIGdWMXGmQ== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 19 Nov 2025 16:13:41 +0100 Message-Id: Cc: "Hui Pu" , "Thomas Petazzoni" , , , , , , , , , To: "Louis Chauvet" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Jonathan Corbet" , "Alexey Brodkin" , "Phong LE" , "Liu Ying" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Adrien Grassein" , "Laurent Pinchart" , "Tomi Valkeinen" , "Kieran Bingham" , "Geert Uytterhoeven" , "Magnus Damm" , "Kevin Hilman" , "Jerome Brunet" , "Martin Blumenstingl" , "Chun-Kuang Hu" , "Philipp Zabel" , "Matthias Brugger" , "AngeloGioacchino Del Regno" , "Anitha Chrisanthus" , "Edmund Dea" , "Inki Dae" , "Seung-Woo Kim" , "Kyungmin Park" , "Krzysztof Kozlowski" , "Alim Akhtar" From: "Luca Ceresoli" Subject: Re: [PATCH 02/26] drm/bridge: deprecate of_drm_find_bridge() X-Mailer: aerc 0.20.1 References: <20251119-drm-bridge-alloc-getput-drm_of_find_bridge-v1-0-0db98a7fe474@bootlin.com> <20251119-drm-bridge-alloc-getput-drm_of_find_bridge-v1-2-0db98a7fe474@bootlin.com> <66cdbe39-d065-4aa4-86e4-84a38b49c09c@bootlin.com> In-Reply-To: <66cdbe39-d065-4aa4-86e4-84a38b49c09c@bootlin.com> X-Last-TLS-Session-Version: TLSv1.3 On Wed Nov 19, 2025 at 3:28 PM CET, Louis Chauvet wrote: > > > On 11/19/25 13:05, Luca Ceresoli wrote: >> of_drm_find_bridge() does not increment the returned bridge >> refcount. drm_of_find_bridge() is to be used as a replacement. >> >> Suggested-by: Maxime Ripard >> Link: https://lore.kernel.org/dri-devel/20250319-stylish-lime-mongoose-0= a18ad@houat/ >> Signed-off-by: Luca Ceresoli ... >> @@ -1452,6 +1452,9 @@ EXPORT_SYMBOL(drm_of_find_bridge); >> * >> * @np: device node >> * >> + * This function is deprecated. Use drm_of_find_bridge() instead for pr= oper >> + * refcounting. >> + * > > I think it should be more explicit that the refcounting is not done by > this function, like: > > This function is deprecated. The returned bridge is not refcounted, you > should not use drm_bridge_put(). Use drm_of_find_bridge() instead for > proper refcounting. OK. -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com