From: "Michael Walle" <mwalle@kernel.org>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Marc Olberding" <molberding@nvidia.com>
Cc: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: Fix w25q01jv flags
Date: Mon, 24 Nov 2025 09:12:38 +0100 [thread overview]
Message-ID: <DEGRVEN1ZNUY.OCJLFWDG8XD4@kernel.org> (raw)
In-Reply-To: <87jyzfzwpw.fsf@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
Hi,
>> + .no_sfdp_flags = SECT_4K,
>
> This one is the right fix and should stand alone in its own patch (first
> in the series if you add support for the block protection).
Only if that flash really doesn't have SFDP. But since the entry
didn't have a size property the flash *must* have SFDP in the first
place. Otherwise it won't even be probed. Please provide a dump of
the SFDP tables, see [1]. Also please provide the contents of
/sys/kernel/debug/spi-nor/spiN.N/params.
-michael
[1] https://docs.kernel.org/driver-api/mtd/spi-nor.html#minimum-testing-requirements
>
>> .fixups = &winbond_nor_multi_die_fixups,
>> }, {
>> .id = SNOR_ID(0xef, 0x50, 0x12),
>
> Thanks,
> Miquèl
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]
next prev parent reply other threads:[~2025-11-24 8:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 22:35 [PATCH] mtd: spi-nor: Fix w25q01jv flags Marc Olberding
2025-11-24 8:00 ` Miquel Raynal
2025-11-24 8:12 ` Michael Walle [this message]
2025-11-24 8:25 ` Miquel Raynal
2025-11-24 8:50 ` Michael Walle
2025-11-24 9:15 ` Miquel Raynal
2025-11-25 0:03 ` Marc Olberding
2025-11-25 7:41 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEGRVEN1ZNUY.OCJLFWDG8XD4@kernel.org \
--to=mwalle@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=molberding@nvidia.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox