public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Tobias Schumacher" <ts@linux.ibm.com>
To: "Heiko Carstens" <hca@linux.ibm.com>,
	"Tobias Schumacher" <ts@linux.ibm.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Sven Schnelle" <svens@linux.ibm.com>,
	"Niklas Schnelle" <schnelle@linux.ibm.com>,
	"Gerald Schaefer" <gerald.schaefer@linux.ibm.com>,
	"Gerd Bayer" <gbayer@linux.ibm.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Matthew Rosato" <mjrosato@linux.ibm.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	<linux-kernel@vger.kernel.org>, <linux-s390@vger.kernel.org>
Subject: Re: [PATCH v6 2/2] s390/pci: Migrate s390 IRQ logic to IRQ domain API
Date: Mon, 24 Nov 2025 11:55:20 +0100	[thread overview]
Message-ID: <DEGVBZFMVBNY.XOWQKJPUIVCI@linux.ibm.com> (raw)
In-Reply-To: <20251121161104.27602Ee9-hca@linux.ibm.com>

On Fri Nov 21, 2025 at 5:11 PM CET, Heiko Carstens wrote:
> On Fri, Nov 21, 2025 at 04:45:43PM +0100, Tobias Schumacher wrote:
>> +static const struct irq_domain_ops zpci_msi_domain_ops = {
>> +	.alloc = zpci_msi_domain_alloc,
>> +	.free  = zpci_msi_domain_free
> ...
>> +static struct msi_parent_ops zpci_msi_parent_ops = {
>> +	.supported_flags   = MSI_GENERIC_FLAGS_MASK	|
>> +			     MSI_FLAG_PCI_MSIX		|
>> +			     MSI_FLAG_MULTI_PCI_MSI,
>> +	.required_flags	   = MSI_FLAG_USE_DEF_DOM_OPS  |
>> +			     MSI_FLAG_USE_DEF_CHIP_OPS,
>> +	.init_dev_msi_info = zpci_init_dev_msi_info
> ...
>> +	struct irq_domain_info info = {
>> +		.fwnode		= irq_domain_alloc_named_fwnode(fwnode_name),
>> +		.ops		= &zpci_msi_domain_ops
>
> All initializers should come with a comma at the end. Anyway, let's wait
> for Gerd. If he is fine with this version I'll add them when applying.

Sorry for that. Since Gert found another issue, I'll fix this one, too.

Thanks,
Tobias

  reply	other threads:[~2025-11-24 10:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21 15:45 [PATCH v6 0/2] genirq: s390/pci: Migrate MSI interrupts to irqdomain API Tobias Schumacher
2025-11-21 15:45 ` [PATCH v6 1/2] genirq: Change hwirq parameter to irq_hw_number_t Tobias Schumacher
2025-11-21 15:45 ` [PATCH v6 2/2] s390/pci: Migrate s390 IRQ logic to IRQ domain API Tobias Schumacher
2025-11-21 16:11   ` Heiko Carstens
2025-11-24 10:55     ` Tobias Schumacher [this message]
2025-11-21 18:31   ` Farhan Ali
2025-11-24  9:09   ` Gerd Bayer
2025-11-24 10:59   ` Heiko Carstens
2025-11-24 10:30 ` [PATCH v6 0/2] genirq: s390/pci: Migrate MSI interrupts to irqdomain API Gerd Bayer
2025-11-24 10:41   ` Tobias Schumacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DEGVBZFMVBNY.XOWQKJPUIVCI@linux.ibm.com \
    --to=ts@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gbayer@linux.ibm.com \
    --cc=gerald.schaefer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=schnelle@linux.ibm.com \
    --cc=svens@linux.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox