From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F38902FFDE1 for ; Thu, 27 Nov 2025 09:48:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764236918; cv=none; b=iKbLBDabQcbcLWHzYQPV3q6zb+AWRpCcBYsJ6Pt4lsFtafs5TvdwYiLYxDv9EXUY92GLqW/7zj8MeALWXLouNyPbGtciopFKWGXyy2KY/ZSzb0MymqWeOvj3hm4o7V8FujgncJNHEojcoSJnuBd9tl+vA7XRDNRkZAqcx892zzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764236918; c=relaxed/simple; bh=XStMOL+VsHB2jWB5eK8Pq7V5pb9ctUX/K4NE+dlDNlU=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=Imk7OrTgVjtn1U8FoFrdfxJ/YpS/2/dbP4g9NbLmDNilWaAYxYZISx5U/5GUhiMTCUqXAfbJd4sJSxGfFo1baUF/kH/fS7XyT8poTRAPZ4FkHS5XGB8gP+DaUqVxVIK4y6tqE94F9m9MgUDvOm5GicNkVJhbgmHYaFtyPo03Gdw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=gMSaUZeL; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="gMSaUZeL" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 38217C16A16; Thu, 27 Nov 2025 09:48:11 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id D85086068C; Thu, 27 Nov 2025 09:48:33 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3FF99102F2343; Thu, 27 Nov 2025 10:48:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1764236913; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=BAZLhFiggp3ISn2IlMvvHN2Lj6HBhB4JUomxmoaFyVk=; b=gMSaUZeLDRdv7XorMV0FKyzctA/4ZSOlfHUNmQrVCZ+WM3vgTMDTAzCIWb21ezNRx4QYJv iwN7ZWp9YPgZVjsmhYZAtipIhD6LRAAeFtP3YsTnGJTfeLLM/FJDqc9twcVfL2ekMnIE5F YYuFFO7zSmMsyeumbEcnqxTOP/JEF+yYjFqviylqeP9fxQaSeGpA6/4T6pNMMAcvJRjl+r q/PQSQdH+7DnYQhMwzXCN2xdbMyxWN4zSYaGmrQ36SKtfFpvzsgum0qiYcjcqE69ftmTn1 ivwmnZKJjCz67sul0Q4lbrdcQLshTZJuxBUgW/CRzkd6w6chphh3z6T3QBm9Cw== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 27 Nov 2025 10:48:26 +0100 Message-Id: From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH 1/2] phy: rockchip: inno-usb2: fix disconnection in gadget mode Cc: "Kever Yang" , "Minas Harutyunyan" , "Alan Stern" , "Louis Chauvet" , =?utf-8?q?Herv=C3=A9_Codina?= , "Thomas Petazzoni" , , , , , To: "Luca Ceresoli" , =?utf-8?q?Th=C3=A9o_Lebrun?= , "Vinod Koul" , "Kishon Vijay Abraham I" , "Heiko Stuebner" , "William Wu" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20250722-rk3308-fix-usb-gadget-phy-disconnect-v1-0-239872f05f17@bootlin.com> <20250722-rk3308-fix-usb-gadget-phy-disconnect-v1-1-239872f05f17@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 On Thu Nov 27, 2025 at 10:22 AM CET, Luca Ceresoli wrote: > On Tue Nov 25, 2025 at 4:28 PM CET, Th=C3=A9o Lebrun wrote: >>> The code already checks for !rport->suspended, so add a guard for VBUS = as >>> well to avoid a disconnection when a cable is connected. >> >> Your commit message was clear but I was missing one key point: what >> rport->suspended means. It isn't what I first thought. Instead it means >> phy is powered off. Naming is bad but unrelated to your series. Maybe >> add a comment to your commit message like the following? >> >> The code already checks for !rport->suspended (PHY is powered on), ... > > You are right. I have added a slightly longer text: > > The code already checks for !rport->suspended (which, somewhat > counter-intuitively, means the PHY is powered on), ... > > Still worth your Reviewed-by? Even more so. > I fixed the other issues you have reported, for patch 2 as well. > > I also added the Cc: stable@vger.kernel.org line, which I noticed being > missing. I never add that Cc trailer and only rely on `Fixes:`. I thought it used to be documented as an alternative to that Cc trailer but it does not show up in `git log -p Documentation/process/stable-kernel-rules.rst` There is one indirect mention of "scripts that look for commits containing a 'Fixes:' tag": https://elixir.bootlin.com/linux/v6.17.9/source/Documentation/process/stabl= e-kernel-rules.rst#L132-L134 Anyway, you do right by explicitly tagging `Cc: stable@...`. Thanks, -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com