From: "Kurt Borja" <kuurtb@gmail.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Kurt Borja" <kuurtb@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Tobias Sperling" <tobias.sperling@softing.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add TI ADS1018/ADS1118
Date: Fri, 28 Nov 2025 12:40:06 -0500 [thread overview]
Message-ID: <DEKIG2EXEUS9.28A50WAN06ZMQ@gmail.com> (raw)
In-Reply-To: <bc76c2c9-ceb6-4ba4-80f0-8a114c5da033@kernel.org>
On Fri Nov 28, 2025 at 4:43 AM -05, Krzysztof Kozlowski wrote:
> On 28/11/2025 04:37, Kurt Borja wrote:
>> +
>> + interrupts:
>> + description: DOUT/DRDY (Data Out/Data Ready) line.
>> + maxItems: 1
>> +
>> + drdy-gpios:
>> + description:
>> + Extra GPIO line connected to DOUT/DRDY (Data Out/Data Ready). This allows
>> + distinguishing between interrupts triggered by the data-ready signal and
>> + interrupts triggered by an SPI transfer.
>> + maxItems: 1
>> +
>> + '#address-cells':
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 0
>
> These two properties are not correct now - you do not have any children.
>
>> +
>> + '#io-channel-cells':
>> + const: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - vdd-supply
>> + - '#address-cells'
>> + - '#size-cells'
>
> And they should not be required.
I'll drop these. Thank you, Krzysztof!
>
>
> Best regards,
> Krzysztof
--
~ Kurt
next prev parent reply other threads:[~2025-11-28 17:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 3:37 [PATCH v2 0/2] iio: Add support for TI ADS1X18 ADCs Kurt Borja
2025-11-28 3:37 ` [PATCH v2 1/2] dt-bindings: iio: adc: Add TI ADS1018/ADS1118 Kurt Borja
2025-11-28 9:43 ` Krzysztof Kozlowski
2025-11-28 17:40 ` Kurt Borja [this message]
2025-11-28 3:37 ` [PATCH v2 2/2] iio: adc: Add ti-ads1018 driver Kurt Borja
2025-11-28 9:54 ` Andy Shevchenko
2025-11-28 10:21 ` Andy Shevchenko
2025-11-28 17:38 ` Kurt Borja
2025-11-28 19:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEKIG2EXEUS9.28A50WAN06ZMQ@gmail.com \
--to=kuurtb@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=tobias.sperling@softing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox