From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83E6B2550CD for ; Mon, 8 Dec 2025 08:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765183822; cv=none; b=i7zfALuKLNUhXKMPVB0vs5h1weDgAgZTPRgeAGx/+Yy9GByOCa9TCFqA5rgCoIxe395VIekJXBpH0DPGSawPchpGQs8L4zuz2pBNHtJ+Jo76CKXIfPDARM0DBZgyAz2796hqnU/fzAFEeMZGSCjRY4OYmmh+eJ8OEfI+ls5jFAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765183822; c=relaxed/simple; bh=dvwhWZpXG0C7coFtUoblPX7odDYWyvXrBvPozjRIksg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=iH7eXOknz5QETu8uRL3VncEk5E13DDle19Y88h5y3aiENHcvJoyeD3cCoSgXDnYqlqaIZ1rpdX3inM8WDQuZZO6VJGDC1se2G6sbLhaPvHu7xc2t4GNKmvzaPBMQLWeLgSwNcCQUhOHWs/rNeNvNcaDIi9+kkTLHgsYJJTHci/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ahScYKYs; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ahScYKYs" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-477563e531cso26967625e9.1 for ; Mon, 08 Dec 2025 00:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765183819; x=1765788619; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=gDi/IyErOIJQYtrl+LBYsvTSFLFtCC7HhN0Jp+L9rZE=; b=ahScYKYsDiNuzD72xpuIX9QFYk6zuMEHGBYb9NskFJf1d8vRRG+NIdQpsso4Gy4loI +PjtaIUuUha8wios/CtZqteFIl2zwoAgQj7SKva5Hzo2UJQuINrm0nW6z5UDWSwUEQ1r OYxHIZdPpGn9Fc78dMrIsS81/yweazRus2UhXs8eg5zaOO0+Ojr40T+caF56ysWv1fvR Z1r8tIVup1gJkkRFXbh1QN6KKHxFU5QUdaMfuh0CDpq2KSvpARsfHnlQapQ0tGiz0qVf fTLOKh4+8F3nZzqTHa3MI9SOiFc2jmw1a78inJtXOGQTSgbIR47XolcadaU4+fu99ozZ Ei2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765183819; x=1765788619; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=gDi/IyErOIJQYtrl+LBYsvTSFLFtCC7HhN0Jp+L9rZE=; b=hTixev56AdTdCz4bQktWCVkYOkVhFmzDPqyfzjAKxSXcxJXFlZ4p6XpGU0FaR4PDzo QvdMi1EgGgEYtuowV65yQv12skQIkM3Ad4lKfTG2WgKUMZ89WQx3yrISuG4bR33qO2rW wpcQS5/Bf7boUKzfE3zC8K6ByEkUBg5Zb3r9BXCAA2ExmugBdM/YO+SkEBFGGI15s+Yf unpau8pIisFIgtIsH+lJy1CKRnjyuDZB7XUWvcZGLEHypJODBRGA94ADJQsCHL847XoH fRR2soMe+lqUn8HoxmhFKjiM2kzC3scMR0jqTQJwrfGkgGASoh0hc3lT4qwrzwLHP1AM p0Qw== X-Forwarded-Encrypted: i=1; AJvYcCX+itrq3DylYTl0sGjZ2LTwN8dS96cu68TG6RKMcVOFCvSN/JF22XryUTRTydt3WtU0Hqo2IEDNalF0tyU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3WxhBB2sXpaSMafaONUwVfy7N1iBr4CO7xlroYjlkbA9/TMcU eMAIzlFAj6ZWY4A0gQ8S6XfPs0j2pQajHakeUnup82CggKT+qM/lhKB+1P3LbjIuUjx0mm13EDV O7LMvdVeBLdj/YQ== X-Google-Smtp-Source: AGHT+IHiSTp/qbmvb4GJVWTUHOBV8VkwtNU8xT1tQLZOhSRfTVYEUMqiw8JMORpvd6wAMev6Vx88+grsOTZH5Q== X-Received: from wmdd27.prod.google.com ([2002:a05:600c:a21b:b0:477:a1f9:138c]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b8b:b0:477:582e:7a81 with SMTP id 5b1f17b1804b1-47939df3288mr77164585e9.4.1765183818842; Mon, 08 Dec 2025 00:50:18 -0800 (PST) Date: Mon, 08 Dec 2025 08:50:17 +0000 In-Reply-To: <20251208083857.GA3707837@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251207-warn-printf-gcc-v1-1-b597d612b94b@google.com> <20251208083857.GA3707837@noisy.programming.kicks-ass.net> X-Mailer: aerc 0.21.0 Message-ID: Subject: Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf() From: Brendan Jackman To: Peter Zijlstra , Brendan Jackman Cc: Andrew Morton , , , , , , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon Dec 8, 2025 at 8:38 AM UTC, Peter Zijlstra wrote: > On Sun, Dec 07, 2025 at 03:53:18AM +0000, Brendan Jackman wrote: >> Recent additions to this function cause GCC 14.3.0 to get excited and >> suggest a missing attribute: >>=20 >> lib/bug.c: In function =E2=80=98__warn_printf=E2=80=99: >> lib/bug.c:187:25: error: function =E2=80=98__warn_printf=E2=80=99 might = be a candidate for =E2=80=98gnu_printf=E2=80=99 format attribute [-Werror= =3Dsuggest-attribute=3Dformat] >> 187 | vprintk(fmt, *args); >> | ^~~~~~~ >>=20 >> Disable the diagnostic locally, following the pattern used for stuff >> like va_format(). > > No real objection, but why haven't I seen this in my own builds? Most of > my machines are on gcc-14 / gcc-15. Ah, yeah, apparently it only shows up with W=3D1.