From: "Kurt Borja" <kuurtb@gmail.com>
To: "Tomas Melin" <tomas.melin@vaisala.com>,
"Kurt Borja" <kuurtb@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Tobias Sperling" <tobias.sperling@softing.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v8 0/2] iio: Add support for TI ADS1X18 ADCs
Date: Fri, 12 Dec 2025 08:10:32 -0500 [thread overview]
Message-ID: <DEW9HATVCPDE.9X0RFCJ4UJMP@gmail.com> (raw)
In-Reply-To: <8568e452-15a5-4a94-aa2a-b7525888799b@vaisala.com>
On Fri Dec 12, 2025 at 3:40 AM -05, Tomas Melin wrote:
> Hi,
>
> Sorry for coming in late in the cycle, can you please explain why the
> driver for ADS1015 could not be extended to support also ADS1x18
> devices? Briefly looking into the topic, they seem to be very closely
> related.
>
> Have You looked into that alternative?
Yes, this was discussed in v1.
Although they are related, these two devices do not use the same
protocol and regmap is not a good fit for ADS1X18. We need two different
SPI message structure for driving the two operating modes (direct,
buffer) and the trigger needs some special considerations because
ads1x18 share their drdy interrupt line with the MOSI pin.
We concluded merging the two drivers would be too messy as both
protocols would need a lot of unique code. Not to mention different
triggers, buffers, custom callbacks, etc.
>
> Thanks,
> Tomas
--
~ Kurt
next prev parent reply other threads:[~2025-12-12 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 4:25 [PATCH v8 0/2] iio: Add support for TI ADS1X18 ADCs Kurt Borja
2025-12-12 4:25 ` [PATCH v8 1/2] dt-bindings: iio: adc: Add TI ADS1018/ADS1118 Kurt Borja
2025-12-12 4:25 ` [PATCH v8 2/2] iio: adc: Add ti-ads1018 driver Kurt Borja
2025-12-14 14:48 ` Jonathan Cameron
2025-12-14 23:53 ` Kurt Borja
2025-12-12 8:40 ` [PATCH v8 0/2] iio: Add support for TI ADS1X18 ADCs Tomas Melin
2025-12-12 13:10 ` Kurt Borja [this message]
2025-12-12 13:50 ` Tomas Melin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEW9HATVCPDE.9X0RFCJ4UJMP@gmail.com \
--to=kuurtb@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=tobias.sperling@softing.com \
--cc=tomas.melin@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).