linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kurt Borja" <kuurtb@gmail.com>
To: "Jonathan Cameron" <jic23@kernel.org>, "Kurt Borja" <kuurtb@gmail.com>
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Tobias Sperling" <tobias.sperling@softing.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v8 2/2] iio: adc: Add ti-ads1018 driver
Date: Sun, 14 Dec 2025 18:53:19 -0500	[thread overview]
Message-ID: <DEYCEJB4SWZ3.13MX1YUFLI1QI@gmail.com> (raw)
In-Reply-To: <20251214144839.2eec58f9@jic23-huawei>

On Sun Dec 14, 2025 at 9:48 AM -05, Jonathan Cameron wrote:
> On Thu, 11 Dec 2025 23:25:44 -0500
> Kurt Borja <kuurtb@gmail.com> wrote:
>
>> Add ti-ads1018 driver for Texas Instruments ADS1018 and ADS1118 SPI
>> analog-to-digital converters.
>> 
>> This chips' MOSI pin is shared with a data-ready interrupt. Defining
>> this interrupt in devicetree is optional, therefore we only create an
>> IIO trigger if one is found.
>> 
>> Handling this interrupt requires some considerations. When enabling the
>> trigger the CS line is tied low (active), thus we need to hold
>> spi_bus_lock() too, to avoid state corruption. This is done inside the
>> set_trigger_state() callback, to let users use other triggers without
>> wasting a bus lock.
>> 
>> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>
> Hi Kurt, 
>
> A couple of minor formatting things. All trivial so I tweaked whilst
> applying. Applied to the testing branch of iio.git. I'll rebase that
> on rc1 once available then push out as togreg for linux-next to pick
> it up.
>
> Thanks,
>
> Jonathan

Hi Jonathan,

Thank you, Andy and David for your guidance (and the little tweaks) :)

-- 
 ~ Kurt

  reply	other threads:[~2025-12-14 23:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-12  4:25 [PATCH v8 0/2] iio: Add support for TI ADS1X18 ADCs Kurt Borja
2025-12-12  4:25 ` [PATCH v8 1/2] dt-bindings: iio: adc: Add TI ADS1018/ADS1118 Kurt Borja
2025-12-12  4:25 ` [PATCH v8 2/2] iio: adc: Add ti-ads1018 driver Kurt Borja
2025-12-14 14:48   ` Jonathan Cameron
2025-12-14 23:53     ` Kurt Borja [this message]
2025-12-12  8:40 ` [PATCH v8 0/2] iio: Add support for TI ADS1X18 ADCs Tomas Melin
2025-12-12 13:10   ` Kurt Borja
2025-12-12 13:50     ` Tomas Melin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DEYCEJB4SWZ3.13MX1YUFLI1QI@gmail.com \
    --to=kuurtb@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=tobias.sperling@softing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).