From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF0D38462 for ; Wed, 17 Dec 2025 14:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765981262; cv=none; b=FqD4/fBLPK/Epg8FL8YZNHqgEFP5Pbe1kIwoQGmJR6Sv7Bpx6u6/rN6GDVxdEBR9NBHLcdGsG60qktkOc21FGqrK9yW5A0Lx3DnPAcxo28ioraQzfpUVGAcS9/WHkLCRmmbYwIQsjynRbfGavRdMXAeK8Ybvd8aWlQCEe0538CA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765981262; c=relaxed/simple; bh=fzuwhM6lbndckRqp5riuGOoINfb0fnQbjhJBQ4T2P2Y=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=IPPH4vb4K/MMB2hngD+RVjlaQlHvwLFBp207kNeXvOWxhcSAOgOOntPh7jbIro5Bf/4d8moJHc8q2mAZH5nY7mLOagjLn7ov9MUy2wIw5nX61tomHQA8aUKuGKj7CLlVidAtMF02b1t90O2/4JjES6DiarR+iWUbt01iGrRvw+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=uo/EpFVW; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="uo/EpFVW" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id E9DC9C1A59E; Wed, 17 Dec 2025 14:20:32 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 7856B6072F; Wed, 17 Dec 2025 14:20:57 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 2AD0C102F0AE7; Wed, 17 Dec 2025 15:20:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765981256; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=fzuwhM6lbndckRqp5riuGOoINfb0fnQbjhJBQ4T2P2Y=; b=uo/EpFVW114mOVRPBJ6qYD906sPlDPXN6KS04EyTCQk5y1TX+kbG/JzkDeugkXJ2ezYT8I oxd6n6GjqVr7w5osstXPY1iHWlwu9tdSbCRbaQI9oU54oVAsYQD8nOzUchcVzDMn3q/O36 3iWM9AGXAJELmC0B3cYuHKVKoIfTVAs3ZPby1bZ4lLuvsxnOgNhGbzgChpU7CV2x1wrP6+ rkufEsTngy2GmQKMyl2Ea7odZkZqV8Eyrzn8PCApU94zRhA2LhHiGg1Rhahcp/YOWZu1Rh DyaVdBflWfKg9JDLDyhcnxQgGy63jUuATOVpWltDbPwZXWFNXSZfuvojxc5LyA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 17 Dec 2025 15:20:49 +0100 Message-Id: From: "Luca Ceresoli" Subject: Re: [PATCH v2 04/20] drm/tilcdc: Add support for DRM bus flags and simplify panel config Cc: "Markus Schneider-Pargmann" , "Bajjuri Praneeth" , "Louis Chauvet" , "Thomas Petazzoni" , "Miguel Gazquez" , , , , , To: "Kory Maincent (TI.com)" , "Jyri Sarha" , "Tomi Valkeinen" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Russell King" , "Bartosz Golaszewski" , "Tony Lindgren" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" X-Mailer: aerc 0.20.1 References: <20251211-feature_tilcdc-v2-0-f48bac3cd33e@bootlin.com> <20251211-feature_tilcdc-v2-4-f48bac3cd33e@bootlin.com> In-Reply-To: <20251211-feature_tilcdc-v2-4-f48bac3cd33e@bootlin.com> X-Last-TLS-Session-Version: TLSv1.3 On Thu Dec 11, 2025 at 5:38 PM CET, Kory Maincent (TI.com) wrote: > Migrate CRTC mode configuration to use standard DRM bus flags in > preparation for removing the tilcdc_panel driver and its custom > tilcdc_panel_info structure. > > Add support for DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE and > DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE flags to control pixel clock and sync > signal edge polarity, while maintaining backward compatibility with the > existing tilcdc panel info structure. > > Simplify several hardware parameters by setting them to fixed defaults > based on common usage across existing device trees: > - DMA burst size: 16 (previously configurable via switch statement) > - AC bias frequency: 255 (previously panel-specific) > - FIFO DMA request delay: 128 (previously panel-specific) > > These parameters show no variation in real-world usage, so hardcoding > them simplifies the driver without losing functionality. > > Preserve FIFO threshold configurability by detecting the SoC type, as > this parameter varies between AM33xx (8) and DA850 (16) platforms. > > Signed-off-by: Kory Maincent (TI.com) Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com