From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5E6034DB51 for ; Wed, 17 Dec 2025 14:26:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765981575; cv=none; b=sSoY/q3TCiV7B+xGN3DkcuRZqzt2H6FqO29WVMtRctLcUfE/VQlqaq92siZMEhjdNefZMpIpP1TInqzt9/Znd3UB9RhKY8BROP4HSGUNmhZg0BksFfRO0VkJQWRop7ldSt4Mj/eespDiYfO/88eddp61UCszwofH4pi+ublko4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765981575; c=relaxed/simple; bh=Kx5AqxsQ5e1S1jySAz6WSVdqKpXXqGJgblqNldVpGOY=; h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc: References:In-Reply-To; b=kjfOOXD6NCATKcDDvYY94zZdVAmIu5AkfFZVpqDxpGDYU1WzHV/fo7MGrIGkymJiTAohqdaLolS5R3F4NxrLGwm+zjpcKk51a+GYqNmTCHvd9G9RWYZGU8OhEBxD7rEeuHhbrFUUVCF6lXVL322AMvw0hImjdG2byc0XbvTOIDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=aXZryHje; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="aXZryHje" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 018524E41C61; Wed, 17 Dec 2025 14:26:11 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C95BD6072F; Wed, 17 Dec 2025 14:26:10 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 740D2102F0AD5; Wed, 17 Dec 2025 15:26:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765981568; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Kx5AqxsQ5e1S1jySAz6WSVdqKpXXqGJgblqNldVpGOY=; b=aXZryHjew7b+veFlQFeIc/4hujos/2S3u2jWCsouWWL35gfB3oO+vyOOG/wVK+g1LpACs/ vDsIbmw/mfAQw20Y9CThqnBr8lbGBFwic0XojTPGqUPODuFwnu6TFNE9E2wGm4mOzx5SdT Y8aE8NeVZ1o+3Gg+nvGoYNp4YCUyZyvGP1fsBvnYcNvyG3oWo5TDKXAnZGt2IgVaWDgb1g cCVqEHnpmplysiDxg6RWeMnAEfx5ispwauQtntYK48cA89DBlS+FUKkxl7l4TW8jrxJ5cq k6gRzGy7ylLkwOh0oQNkaFscL08PKyIq63lOMxQkaQqjKraCYZ3yOXjgHRlpMQ== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 17 Dec 2025 15:26:05 +0100 Message-Id: To: "Kory Maincent (TI.com)" , "Jyri Sarha" , "Tomi Valkeinen" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Russell King" , "Bartosz Golaszewski" , "Tony Lindgren" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" From: "Luca Ceresoli" Subject: Re: [PATCH v2 15/20] drm/tilcdc: Remove the use of drm_device private_data Cc: "Markus Schneider-Pargmann" , "Bajjuri Praneeth" , "Louis Chauvet" , "Thomas Petazzoni" , "Miguel Gazquez" , , , , , X-Mailer: aerc 0.20.1 References: <20251211-feature_tilcdc-v2-0-f48bac3cd33e@bootlin.com> <20251211-feature_tilcdc-v2-15-f48bac3cd33e@bootlin.com> In-Reply-To: <20251211-feature_tilcdc-v2-15-f48bac3cd33e@bootlin.com> X-Last-TLS-Session-Version: TLSv1.3 On Thu Dec 11, 2025 at 5:38 PM CET, Kory Maincent (TI.com) wrote: > The DRM core documentation recommends against using dev_private: > "Instead of using this pointer it is recommended that drivers use > embed the struct &drm_device in their larger per-device structure." > > This patch refactors the tilcdc driver to follow this recommendation > by embedding struct drm_device within struct tilcdc_drm_private and > replacing all dev->dev_private accesses with the ddev_to_tilcdc_priv() > helper macro that uses container_of(). > > This change aligns the driver with modern DRM best practices. > > Signed-off-by: Kory Maincent (TI.com) Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com