From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43599257852 for ; Thu, 18 Dec 2025 14:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766067832; cv=none; b=cSbf6odC1W/G8Cand9uTQFoVNfamTlgVKcqR3j2NUnCVwYPOxqrxcYat4Le7v0ReAtsigCAwAAF7s8OtuwlPmzOGXa6R3h13JAID1IibusnDY9OWy0pi/pp9/dCIP3ctoGNDs7gZ3Gx6bLjGSHbI9oOG6yirAyGvlKbRFITmADI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766067832; c=relaxed/simple; bh=IchqKkM1bd+yGaVg6uSU5HkGkxw95z8S5Xb35oyo9pg=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=ba1k1P42+E704oSGcHn2e2FAHsbfLAnZ17iXjMRPF0TeSS7l8mrGJfzZpwEofyKi1sXt+HIoupElt9W2EHi+wW9Nzpt0/SC5dI0dvRWEVOC7K1O64e7u8UN6PyjDU0hhf2+sglypOBfydA0d3jJlGf/LnH2SqpET2E22GXasqkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=a+In6PYb; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="a+In6PYb" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id D8203C1A5AF; Thu, 18 Dec 2025 14:23:23 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 666E8606B6; Thu, 18 Dec 2025 14:23:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9E7DA102F0ADC; Thu, 18 Dec 2025 15:23:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1766067826; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=IchqKkM1bd+yGaVg6uSU5HkGkxw95z8S5Xb35oyo9pg=; b=a+In6PYbA1mKvlCzytMKYpqqpNmweyhmmw64DSVm4U+rsYr85nTYAmMTHwlSJxtvBEqHtX RG9L3e6YQz4sa5m6aGWPUxiiWGVSjyLEhN/exrd+gqJsEzD6+adDnHdgIfJ3I3l/Ub95cr m6ZRun7wYQt/QWLrY3qfpzufBblU8xBkL+Utf8jtZleFt+RjBTfCpdlQdNfOOFg5/PpE9z 5htB1/d1tqdWQuW8jHkAUioZ4BTEQOj+gDUMJi3re9Q7kkog3zWzduDBkGH3HNeS+tDjFt 4dYjI2/PRcpHsOnjTrNzjrxj4/8LPmAtI5S/TkoiZi1fp8Gw+8giOGUZ+OhdaQ== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 18 Dec 2025 15:23:35 +0100 Message-Id: From: "Luca Ceresoli" Subject: Re: [PATCH v3 01/22] drm/bridge: add of_drm_find_and_get_bridge() Cc: , , , , , , "Alexey Brodkin" , "Andrzej Hajda" , "David Airlie" , "Fabio Estevam" , "Hui Pu" , "Jernej Skrabec" , "Jerome Brunet" , "Jonas Karlman" , "Jonathan Corbet" , "Kevin Hilman" , "Laurent Pinchart" , "Liu Ying" , "Maarten Lankhorst" , "Martin Blumenstingl" , "Neil Armstrong" , "Pengutronix Kernel Team" , "Phong LE" , "Robert Foss" , "Sascha Hauer" , "Shawn Guo" , "Simona Vetter" , "Thomas Petazzoni" , "Thomas Zimmermann" To: "Maxime Ripard" X-Mailer: aerc 0.20.1 References: <20251216-drm-bridge-alloc-getput-drm_of_find_bridge-v3-1-b5165fab8058@bootlin.com> <0ba037c65f9cadd51082abf2b7857ba7@kernel.org> <20251218-shiny-rugged-bug-d1d3e8@houat> In-Reply-To: <20251218-shiny-rugged-bug-d1d3e8@houat> X-Last-TLS-Session-Version: TLSv1.3 Hi Maxime, On Thu Dec 18, 2025 at 1:50 PM CET, Maxime Ripard wrote: > Hi, > > On Wed, Dec 17, 2025 at 03:31:01PM +0100, Luca Ceresoli wrote: >> On Wed Dec 17, 2025 at 11:15 AM CET, Maxime Ripard wrote: >> > On Tue, 16 Dec 2025 18:58:34 +0100, Luca Ceresoli wrote: >> >> of_drm_find_bridge() does not increment the refcount for the returned >> >> bridge, but that is required now. However converting it and all its u= sers >> >> is not realistically doable at once given the large amount of (direct= and >> >> indirect) callers and the complexity of some. >> >> >> >> >> >> [ ... ] >> > >> > Reviewed-by: Maxime Ripard >> >> Thank you for the prompt review! >> >> All patches are reviewed now except patch 18 which has no reply. I'm jus= t >> pointing out in case it's something you missed. > > Yes, I couldn't really understand the implications of that one, so I'll > leave the review to the maintainers. OK, make sense, it's not a trivial patch to review. Patches 1-4,6 contain the core changes and they are all reviewed, which is the most important part to me. Everything else is just "a bunch of driver conversions" and they can flow in over time. I'm also sending more such driver conversions in separate series, for other drivers. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com