Re: [PATCH RESEND v2 25/32] drm/vkms: Introduce configfs for connector supported colorspace

Luca Ceresoli
2025-12-19T18:56:09Z

On Wed Oct 29, 2025 at 3:37 PM CET, Louis Chauvet wrote:
> Add the attribute supported_colorspaces to configure the supported
> colorspace of a connector. It will allows emulating some HDR features of
> displays. This feature is only supported for HDMI, DP and eDP connectors.
>
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> --- a/drivers/gpu/drm/vkms/vkms_configfs.c
> +++ b/drivers/gpu/drm/vkms/vkms_configfs.c
> @@ -1223,12 +1223,51 @@ static ssize_t connector_type_store(struct config_item *item,
> return count;
> }
>
> +static ssize_t connector_supported_colorspaces_show(struct config_item *item, char *page)
> +{
> + struct vkms_configfs_connector *connector;
> + int type;

This variable name is not really intuitive. 'colorspaces' maybe?

With that change:

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering