Re: [PATCH RESEND v2 04/32] drm/vkms: Explicitly display connector status

José Expósito
2025-11-13T14:11:24Z

On Wed, Oct 29, 2025 at 03:36:41PM +0100, Louis Chauvet wrote:
> Debug information are mainly read by human, so use full name instead
> of raw values for connector status.

These simple patches improving vkms_config_show() could be merged
independently if it makes easier your work.

Thanks for these changes!

Reviewed-by: José Expósito <jose.exposito@redhat.com>

> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> ---
> drivers/gpu/drm/vkms/vkms_config.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_config.c b/drivers/gpu/drm/vkms/vkms_config.c
> index 391794d391c5..858bec2d1312 100644
> --- a/drivers/gpu/drm/vkms/vkms_config.c
> +++ b/drivers/gpu/drm/vkms/vkms_config.c
> @@ -3,6 +3,7 @@
> #include <linux/slab.h>
> #include <linux/string_choices.h>
>
> +#include <drm/drm_connector.h>
> #include <drm/drm_print.h>
> #include <drm/drm_debugfs.h>
> #include <kunit/visibility.h>
> @@ -364,8 +365,8 @@ static int vkms_config_show(struct seq_file *m, void *data)
>
> vkms_config_for_each_connector(vkmsdev->config, connector_cfg) {
> seq_puts(m, "connector:\n");
> - seq_printf(m, "\tstatus=%d\n",
> - vkms_config_connector_get_status(connector_cfg));
> + seq_printf(m, "\tstatus=%s\n",
> + drm_get_connector_status_name(vkms_config_connector_get_status(connector_cfg)));
> }
>
> return 0;
>
> --
> 2.51.0
>