Re: [PATCH RESEND v2 29/32] drm/vkms: Rename vkms_connector_init to vkms_connector_init_static

Louis Chauvet
2025-12-19T19:11:08Z

On 12/19/25 19:58, Luca Ceresoli wrote:
> On Wed Oct 29, 2025 at 3:37 PM CET, Louis Chauvet wrote:
>> With the introduction of dynamic connectors we will have two way of
>> initializing a VKMS connector. Rename the current function to clarify
>> the case.
>>
>> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
>
>> --- a/drivers/gpu/drm/vkms/vkms_connector.h
>> +++ b/drivers/gpu/drm/vkms/vkms_connector.h
>> @@ -4,6 +4,7 @@
>> #define _VKMS_CONNECTOR_H_
>>
>> #include "vkms_drv.h"
>> +#include "vkms_config.h"
>
> Why? Maybe this is for another patch in the series?

This line is useful, I use struct vkms_config_connector
But I agree, this should be a separate patch.

> With that line removed:
>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
>
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com