From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6B013242B1 for ; Fri, 19 Dec 2025 20:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766177274; cv=none; b=gwgBxkyxwT09pBsIG9E9CALpgQ/0PpZKDmdXp+8s/h8Uz/GQDOelexeVo/S8WFMA2DCswEcig8VZ3WYJshGtZlKdrOHxJl0+FzFWd9qV17hc6uN+foAX9wGUdkAE8mcBQzofVDKHxjyi6lH4e75QBB/oQ0hAtD6pBtackkdZRXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766177274; c=relaxed/simple; bh=QmKCwA9OiMZoZoLMNkNi6moVnZc7AFF6KOUlW7rO9d0=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=NHeuZ5+r6FzWv+xPvCG2o1BjrN3rgMeRSwQeWMV12D8W+twtAKoeJNbOfDT9FpjSVjj1wtjFC9ClA3hhK/Al2IvBX0bTfhtC6XpWe3MWQdnQWo/Moy22ygDgJMmFdg92qCwRGVHNBtLa1oJf5C+JOR0xRsXj+zgXwSQVQNkjO7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=woMpxApf; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="woMpxApf" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 47425C1B20F; Fri, 19 Dec 2025 20:47:26 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 091AB6071D; Fri, 19 Dec 2025 20:47:51 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1EA8510AA9874; Fri, 19 Dec 2025 21:47:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1766177267; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=ZPEqfLqdo5J8DXEk0J+Okhr1M8II1hSBSmQl5uQm7xI=; b=woMpxApfwuqx5dBF50MGRZ8LZyXB0Oc2hshn2/ds2WkY3r6lXhQOwwRs4XZppQJSeegDvF FIhjilWrgSKLz1bP7hRvL118edVOxWT6OTniYnIleqNmzFSMgJ4vduXzu0SbkDHR2lLiTY PmqGs+nwm6glXb+B9bPLBJzfqKqIcMlQAHqfYPok3/oEWe5AwDNE9BPt3z2eC8Amqi40jN +o9NeCXeOE5NgWf/pEAwqPh7pceq18EUF5HGtTaw2005K0h0HWPBrOTY6i8zkxZBukIH5N d/C7SKzVbWN+cMswR3FNOghd3lM9PvFvx8N7/glC3Wkn/Pv/LCMitBdI/jsr5w== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 19 Dec 2025 21:47:44 +0100 Message-Id: Subject: Re: [PATCH RESEND v2 32/32] drm/vkms: Introduce configfs for dynamic connector creation Cc: , , , , , To: "Louis Chauvet" , "Haneen Mohammed" , "Simona Vetter" , "Melissa Wen" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , , "Jonathan Corbet" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20251029-vkms-all-config-v2-0-a49a2d4cba26@bootlin.com> <20251029-vkms-all-config-v2-32-a49a2d4cba26@bootlin.com> In-Reply-To: <20251029-vkms-all-config-v2-32-a49a2d4cba26@bootlin.com> X-Last-TLS-Session-Version: TLSv1.3 On Wed Oct 29, 2025 at 3:37 PM CET, Louis Chauvet wrote: > DRM allows the connector to be created after the device. To allows > emulating this, add two configfs attributes to connector to allows this. > > Using the dynamic attribute you can set if a connector will be dynamic or > not. > Using the enabled attribute, you can set at runtime if a dynamic connecto= r > is present or not. > > Co-developed-by: Jos=C3=A9 Exp=C3=B3sito > Signed-off-by: Jos=C3=A9 Exp=C3=B3sito > Signed-off-by: Louis Chauvet > --- a/drivers/gpu/drm/vkms/vkms_configfs.c > +++ b/drivers/gpu/drm/vkms/vkms_configfs.c > @@ -1215,8 +1223,10 @@ static ssize_t connector_type_store(struct config_= item *item, > } > > scoped_guard(mutex, &connector->dev->lock) { > - if (connector->dev->enabled) > - return -EINVAL; > + if (connector->dev->enabled) { > + if (connector_is_enabled(connector->config)) > + return -EBUSY; > + } You are changing from -EINVAL to -EBUSY. Why? Was -EINVAL wrong in the first place? And you can avoid the nested if: if (connector->dev->enabled && connector_is_enabled(connector->config)) return -E; > +static ssize_t connector_dynamic_show(struct config_item *item, char *pa= ge) > +{ > + struct vkms_configfs_connector *connector; > + bool enabled; ^^^^^^^ dynamic Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com