From: "Alexey Klimov" <alexey.klimov@linaro.org>
To: "Johan Hovold" <johan@kernel.org>,
"Srinivas Kandagatla" <srini@kernel.org>,
"Mark Brown" <broonie@kernel.org>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
<linux-sound@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ASoC: codecs: pm4125: drop bogus container_of() error handling
Date: Mon, 22 Dec 2025 04:22:28 +0000 [thread overview]
Message-ID: <DF4GIFQ51LXM.243ZASZKP9NJ7@linaro.org> (raw)
In-Reply-To: <20251219142715.19254-2-johan@kernel.org>
On Fri Dec 19, 2025 at 2:27 PM GMT, Johan Hovold wrote:
> The dev_to_sdw_dev() helper uses container_of() to return the containing
> soundwire device structure of its pointer argument and will never return
> NULL.
>
> Fixes: 8ad529484937 ("ASoC: codecs: add new pm4125 audio codec driver")
> Cc: Alexey Klimov <alexey.klimov@linaro.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
I was about to ask to check other drivers/codecs, most likely
wcd937x as one of the reference points to pm4125 codec,
but you already did. Thank you for checking this.
Acked-by: Alexey Klimov <alexey.klimov@linaro.org>
Best regards,
Alexey
next prev parent reply other threads:[~2025-12-22 4:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 14:27 [PATCH 0/3] ASoC: drop bogus container_of() error handling Johan Hovold
2025-12-19 14:27 ` [PATCH 1/3] ASoC: codecs: pm4125: " Johan Hovold
2025-12-22 4:22 ` Alexey Klimov [this message]
2025-12-19 14:27 ` [PATCH 2/3] ASoC: codecs: wcd937x: " Johan Hovold
2025-12-19 14:27 ` [PATCH 3/3] ASoC: soc_sdw_utils: " Johan Hovold
2025-12-19 14:47 ` Konrad Dybcio
2025-12-20 18:56 ` [PATCH 0/3] ASoC: " Dmitry Baryshkov
2025-12-22 22:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF4GIFQ51LXM.243ZASZKP9NJ7@linaro.org \
--to=alexey.klimov@linaro.org \
--cc=broonie@kernel.org \
--cc=johan@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox