From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C82A271A9A for ; Wed, 29 Apr 2026 03:07:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777432026; cv=none; b=kOXZ0fRUAK8+2OY1s5uFYhpE+HtLOhtb2TqbbFvhTcu33Gw7mNFihC6Kphfs6gZOYiZOC8mJ+68LO8ElscgubQ53EJbfuOxSrw4et4PSiYE3gAP/FandVGSAvGR8R7d2Lk0WGYDACjt6GIDl7V4xm1Ne7d8ZUPHfCZs2mw29jdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777432026; c=relaxed/simple; bh=eDv6h7yVjE69Bl/52yrJfaP/dRBySLoR9AlyF21S+2s=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=Du3+AlOo3Fx03/6R3SpjaPl782LBYXlUjGn5CRdbmDW1BkADq0VNnLVMzKThPRqVbI7NjK8AGi3gTe6DXzTqqEEAThdVBzFYIUav9pdN/3iQqlBsK9BE+y+AAxONTt/4m+wmeBtQ6HK4gTMG2CxMh+TvUimOHSaeF+TqOVor8k0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=aL08m9g9; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="aL08m9g9" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1777432022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NhojB57CLlcZgK90/1HI+G25tK+txX7jWmOanRsdL0M=; b=aL08m9g9shhLJMe46gCutiIdCVuOgIS44YbIr4/G/lym4ejJlYaBtoK8OFFXojy/meT57h XQSPG9BJOku37RiHe/4aPLkzIyCWLUD3d4elxp7qHwkTWbJ5yujze5lnUR0eKglPtLPAoJ fSOfc5E92JJcr5+/W7LdWSgyudYnvCU= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.500.181\)) Subject: Re: [PATCH 10/49] mm: move subsection_map_init() into sparse_init() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Wed, 29 Apr 2026 11:06:15 +0800 Cc: Muchun Song , Andrew Morton , David Hildenbrand , Oscar Salvador , Michael Ellerman , Madhavan Srinivasan , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nicholas Piggin , Christophe Leroy , aneesh.kumar@linux.ibm.com, joao.m.martins@oracle.com, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260405125240.2558577-1-songmuchun@bytedance.com> <20260405125240.2558577-11-songmuchun@bytedance.com> To: Mike Rapoport X-Migadu-Flow: FLOW_OUT > On Apr 28, 2026, at 15:06, Mike Rapoport wrote: >=20 > On Sun, Apr 05, 2026 at 08:52:01PM +0800, Muchun Song wrote: >> Move the initialization of the subsection map from free_area_init() >> into sparse_init(). This encapsulates the logic within the sparse >> memory initialization code. >>=20 >> Signed-off-by: Muchun Song >=20 > Acked-by: Mike Rapoport (Microsoft) Thanks. >=20 >> --- >> mm/internal.h | 5 ++--- >> mm/mm_init.c | 10 ++-------- >> mm/sparse-vmemmap.c | 11 ++++++++++- >> mm/sparse.c | 1 + >> 4 files changed, 15 insertions(+), 12 deletions(-) >>=20 >> diff --git a/mm/internal.h b/mm/internal.h >> index edb1c04d0617..d70075d0e788 100644 >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -1004,10 +1004,9 @@ static inline void sparse_init(void) {} >> * mm/sparse-vmemmap.c >> */ >> #ifdef CONFIG_SPARSEMEM_VMEMMAP >> -void sparse_init_subsection_map(unsigned long pfn, unsigned long = nr_pages); >> +void sparse_init_subsection_map(void); >> #else >> -static inline void sparse_init_subsection_map(unsigned long pfn, >> - unsigned long nr_pages) >> +static inline void sparse_init_subsection_map(void) >> { >> } >> #endif /* CONFIG_SPARSEMEM_VMEMMAP */ >=20 > I side note: we might want to split out mm/sparse.h and also move some > declarations from include/linux/mmzone.h there. I think we can do that in a separate series for cleanup only. Thanks.