From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCF841E89C for ; Wed, 31 Dec 2025 14:10:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767190205; cv=none; b=sVe/QGQdqYYXsv6o7WDkQIquuy7RCEtS5FkcvxV3faZrZc0ASwcJuY0Supyvq0ResSoWE7zKs8G0ZOoZ02lDR04JTiYtfWZ1oErPgknITrj21rv00xDMoRRXe0cCqaXg46A1Xh1RRcR8cvL2MKT1hLJsYhLad6LNubs1Zh18JDQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767190205; c=relaxed/simple; bh=XMKAdwbb7kgbXpoE9wLrIawJFDpFSgbLPnAok/1MR4U=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=k0KHB/VAIa6MnFtwv5iyZGvmOuw4r62oMqhFl/YT63ED2/PP1ijx0RgC0SE3arHZQJ4VAdo0TpXf8c38iFEmTG3PoNQ8m84F/FdQlQhjzuGN0Bjq2cTbwuJ4bSrhkXm1aLRijWM9SW3gU9Z549BVB6Xr3C1H3bSHJQM41mcWVpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=k8Bg++C5; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="k8Bg++C5" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id ECD8C4E41EB5; Wed, 31 Dec 2025 14:10:00 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 71D8060744; Wed, 31 Dec 2025 14:10:00 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DA1C7113B0768; Wed, 31 Dec 2025 15:09:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1767190199; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Kwmt6Ld2ymKsGv8aHlzarXZ4Mpw1oBA58a1vcP2IVBU=; b=k8Bg++C50iPo3h/1+U7lERfby7onNJWRCYqg6clGSVa0vvkS8O+UT0PL3hC1DQXe4pRyCk lo9bC1vgVXho4dnby9mFl+p80fd2RPtE7L0qCfyfdqf6L9WD1/MXP3Ohk46oDbKw1v7Smm IrtQKEKfy/6lKIetZ0WB2Ixzkg0kXlcJnGyxOpfrFwu/O3Orwlp0DMyHE0zOfDffnkxJqK 7F7oVKWnHl06pSS4mVrFj6WYfGwKJZARKMkK1W7394uucSeFpcmhW5Y3+vdHP73Zmrl62i eDTJnzUqoqnIaPtvoAGP8ToqtfazEzX8Z/thOINKfWxNytDF/HjDSbL6Uby4mg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 31 Dec 2025 15:09:51 +0100 Message-Id: Subject: Re: [PATCH] drm/bridge: synopsys: dw-dp: return when attach bridge fail Cc: "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , , To: "Osama Abdelkader" , "Andy Yan" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20251226223229.123860-1-osama.abdelkader@gmail.com> In-Reply-To: <20251226223229.123860-1-osama.abdelkader@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 On Fri Dec 26, 2025 at 11:32 PM CET, Osama Abdelkader wrote: > When drm_bridge_attach() fails, the function should return an error > instead of continuing execution. > > Signed-off-by: Osama Abdelkader Looks like a bugfix, should it have a 'Fixes:' tag and 'Cc: stable@...'? See https://docs.kernel.org/process/submitting-patches.html > --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c > @@ -2062,8 +2062,10 @@ struct dw_dp *dw_dp_bind(struct device *dev, struc= t drm_encoder *encoder, > } > > ret =3D drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_C= ONNECTOR); > - if (ret) > + if (ret) { > dev_err_probe(dev, ret, "Failed to attach bridge\n"); > + return ERR_PTR(ret); > + } > > dw_dp_init_hw(dp); > It could be more concise, without adding braces: if (ret) return ERR_PTR(dev_err_probe(dev, ret, "Failed to attach bridge\n")); Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com