public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Benno Lossin" <lossin@kernel.org>
To: "Tamir Duberstein" <tamird@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] scripts: generate_rust_analyzer: match rust/Makefile
Date: Fri, 02 Jan 2026 21:05:09 +0100	[thread overview]
Message-ID: <DFEDG6TK5AY9.1Y9EPEYQLMCMX@kernel.org> (raw)
In-Reply-To: <CAJ-ks9nJ149Dt2v5Dn0A3+Qw=TnzE84Lm3Ridrfrc=mdhFt-MA@mail.gmail.com>

On Fri Jan 2, 2026 at 4:25 PM CET, Tamir Duberstein wrote:
> @Benno would you mind having a look at this series?

Oh wow this is an old series! Sorry for missing it.

I'm not maintaining the build system for pin-init, but from my side the
changes look okay. The commit messages are missing some context though:
why do we need these dependency edges? etc. If you fix that you can add

Acked-by: Benno Lossin <lossin@kernel.org>

Also note that this might be different in the new build system.

Cheers,
Benno

> On Wed, Jul 23, 2025 at 11:39 AM Tamir Duberstein <tamird@kernel.org> wrote:
>>
>> Minor fixes in this series. The main one is fixing navigation in
>> pin_init_internal.
>>
>> This is my first series using tamird@kernel.org; please excude any
>> hiccups.
>>
>> Signed-off-by: Tamir Duberstein <tamird@kernel.org>
>> ---
>> Tamir Duberstein (3):
>>       scripts: generate_rust_analyzer: Add compiler_builtins -> core dep
>>       scripts: generate_rust_analyzer: Add pin_init -> compiler_builtins dep
>>       scripts: generate_rust_analyzer: Add pin_init_internal deps
>>
>>  scripts/generate_rust_analyzer.py | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> ---
>> base-commit: dff64b072708ffef23c117fa1ee1ea59eb417807
>> change-id: 20250723-rust-analyzer-pin-init-925467269001
>>
>> Best regards,
>> --
>> Tamir Duberstein <tamird@kernel.org>
>>

  reply	other threads:[~2026-01-02 20:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 15:39 [PATCH 0/3] scripts: generate_rust_analyzer: match rust/Makefile Tamir Duberstein
2025-07-23 15:39 ` [PATCH 1/3] scripts: generate_rust_analyzer: Add compiler_builtins -> core dep Tamir Duberstein
2026-01-14  9:20   ` Jesung Yang
2025-07-23 15:39 ` [PATCH 2/3] scripts: generate_rust_analyzer: Add pin_init -> compiler_builtins dep Tamir Duberstein
2026-01-14  9:25   ` Jesung Yang
2025-07-23 15:39 ` [PATCH 3/3] scripts: generate_rust_analyzer: Add pin_init_internal deps Tamir Duberstein
2026-01-14  9:26   ` Jesung Yang
2026-01-14 10:29     ` Miguel Ojeda
2026-01-14 10:32       ` Miguel Ojeda
2026-01-14 14:56         ` Tamir Duberstein
2026-01-14 15:47           ` Miguel Ojeda
2026-01-14 10:51   ` Jesung Yang
2026-01-02 15:25 ` [PATCH 0/3] scripts: generate_rust_analyzer: match rust/Makefile Tamir Duberstein
2026-01-02 20:05   ` Benno Lossin [this message]
2026-01-02 20:34     ` Tamir Duberstein
2026-01-03  9:58       ` Benno Lossin
2026-01-03 15:19         ` Tamir Duberstein
2026-01-13 18:31           ` Miguel Ojeda
2026-01-15 13:19 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFEDG6TK5AY9.1Y9EPEYQLMCMX@kernel.org \
    --to=lossin@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox