From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ECB91A0B15 for ; Sat, 3 Jan 2026 09:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767432373; cv=none; b=Hr5cuXMneBO1TyKnqgSSzBSa5iPci0N/WdlAnuw7/H0z3R6cFE7t8qctCZv28S69fKVZk9Nu54HvUXUu/PTekkwmMdSzIRKi0aW4PCHyCdOy7+Tmxq57obNo1x4IroAmmZv0Wb+VLpPHi1JzrRmCUujNI2dzg1T0vNPU1kIf6XE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767432373; c=relaxed/simple; bh=vle9Ag7qibu12+pOyrt/t56LIo2yum2fFZGs3HL+p14=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=QYOMcO6NKzkY7Oa+KCFYklZAEA3hBMpTvyVn+yuD9DGRDdCmZjYiv6F1pB3JF66vLIc4wsFRaJK3BlWLux6XKX9gJ63FyoqozPJhUSbFXAJ8aYPU13y/Ph0Qv0XqOyvvReln1KLUZYKkCerGrTOurTmyYMMHch1AMlVISm73svM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fa7gweeb; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fa7gweeb" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7e1651ae0d5so9805847b3a.1 for ; Sat, 03 Jan 2026 01:26:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767432371; x=1768037171; darn=vger.kernel.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Dw9/KIR+ZU50XPgCeIcMYWC/Y8rEfWLDvWIbH1mNUiQ=; b=Fa7gweebw4PtOUAo8iHF/bVRfEUoMt5Jqmd9vhRjzxWphyKpNkcoRzXXUkmM0kuc/T Ucz2McOD3cIBkQoi6dQxXDSNx8I0Q3SXABZnmguFsRlIQv5YAmQuXFFWy0UYXkhG9P2r DQY9eONKkCqdRmDiNSwppZOmCQo2SnrkrJuiX7SrSTVJEXLL61FUEqUpIb4VAiWqYL1I RPk9+xQeE0YpjinGC3jFJ5/LMvSAqCTxO8JrFJ6fRUTnoYER42/IL2F5mW2Rz5FZSrcK uBwrQVFokoy40OJvs1W/5glqJ/GnYRfFXGBVk3qzR8TG9UrfSBqw/w226q6v1BWrOoB3 Yaaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767432371; x=1768037171; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Dw9/KIR+ZU50XPgCeIcMYWC/Y8rEfWLDvWIbH1mNUiQ=; b=cbM9drtURWWzFDSgrnD07yvFlAr4eOdUtT5ZkqLLV6wLf2X5WZ+b0ZIF65Iju1zGsq pLIOlfZet+gv6TtcWWyisUg6NKr5m9dXJg1+yUVgUM3vOIO4H8dKWd4MxADQwuxarPyg BnmlX5OSvgpbCIYILm6Q+j2rUXZf30eKR7tyTD/QUrCZF0zr9AhYlE/jhok/X5nQXrOb tnNvRg3xJ7WX17t+ddzo6Q+fs91frEDjUcfPGA2iaBqLcHyFXMrhTSBJ0pzS6zdj0TmD acTOoUyilXHGkDiYrE4EKIJnjpZG9nt+gWqQ5DfmNPZ/2W36t+gkd29ridUPSGq24TMp luLg== X-Forwarded-Encrypted: i=1; AJvYcCVgXMs/tsLu5XFPhaQYFwwOF1mm/4Ht72PiUptRrrl/Y7eFO5+k0RWN5TNN5aaikKHGelh+CyQ5I0rYPYY=@vger.kernel.org X-Gm-Message-State: AOJu0YwI/mDSyenHyAcy99UW/cz1A9Vv0cgFSaopc59dHuhS92rA14dT xtv01uQXWYOqcs2iqJ2g+nam6TF9CtVBfMxrYsi/LRC0M3SrG7/SOZOH7fWwKw== X-Gm-Gg: AY/fxX7XJSyrOoHZDUhU5rBHP0ziRQI+BO6ro7se9b+Aeghv2U89cO+RVFUpXXzL46f 1uOY7HJsQyXqwTP87f8ngkicptLrPwQO7md4ZUICrd3dhhszHtvNbgfQfOdeIPuth/OGqvjGSRg n94fhVBnOLVxB6aNSXpSRgkjgJgcAkz42fOcE5zSBZReEzEFOzR2mxbee5/DiKmCwBeDZA0UbMv 8g7OhkhnKvVssUZLZIaZvgKDC2lKm85LwQSS9UlIsMyneTu16ni+WtciH+ht3VbnRsjDqkXiRMB q4WdSpZ51HWs7UwFsg9O0JP3vKLxNipmvesuzHhWI12uBh/AcainiMW+fRW37hZb4uXsVCSJ/6r HuiVbznbdnr3VBnn9hVVFo8XKcwKIQfXJlbEqa/q0OHJ7ZetSV0f7XgYKBE4wqlbT8pbY9kTU58 cPedv2 X-Google-Smtp-Source: AGHT+IG2jZDZEbShKoJpVv1TUdpfWfLrmFxohCD7Sq/sA17KMjrfWcbqTnIgpWHlgwxUfYNjpGk57g== X-Received: by 2002:a05:6a20:5483:b0:32d:a91a:7713 with SMTP id adf61e73a8af0-376a96b9012mr43783710637.40.1767432371306; Sat, 03 Jan 2026 01:26:11 -0800 (PST) Received: from localhost ([61.82.116.93]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1e7bd61b4csm36930157a12.18.2026.01.03.01.26.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Jan 2026 01:26:10 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 03 Jan 2026 18:26:07 +0900 Message-Id: Subject: Re: [PATCH net] net: dlink: mask rx_coalesce/rx_timeout before writing RxDMAIntCtrl Cc: "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , , To: "Paolo Abeni" , "Andrew Lunn" , "Yeounsu Moon" From: "Yeounsu Moon" X-Mailer: aerc 0.21.0 References: <20251223001006.17285-1-yyyynoom@gmail.com> <73f3d573-c093-469b-ac7e-36fdb7832933@redhat.com> In-Reply-To: <73f3d573-c093-469b-ac7e-36fdb7832933@redhat.com> On Tue Dec 30, 2025 at 7:57 PM KST, Paolo Abeni wrote: > I'm not sure we can do such change: any eventual user with bad setting > will get a broken setup after kernel update. I think we should avoid > such regression, and use something similar to this patch. > > @Yeounsu: the type cast in the current patch is not needed, please drop > it, thanks! > > Paolo Thank you for the review. I'll send v2 patch as suggested. Separately, I agree with Andrew that it would be useful to alert users when an invalid value is provided. Would it be OK to send a net-next follow-up that warns (via netdev_warn()) when rx_coalesce or rx_timeout exceeds 16 bits, while keeping the current behavior (no -EINVAL)? Yeounsu Moon