From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BFD43A0B2D for ; Wed, 7 Jan 2026 19:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767814654; cv=none; b=IB8vc+SbgzVKAOQwf+5JO1L8l+Hh1R/vGqah48RTBwAJZdQwCoid/5bubYhsMTfE7ohQdSDAL7ixLMnrg5TaOtPHUocDpZacUnXHiU14z9XeNhvNK24v0CtgUiHXmHx/nKyACr/zUn6id9waFVOT/NcVbDdRF7WwfkD5R+CNgKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767814654; c=relaxed/simple; bh=zh7AsHKYUmDaLaUQjTHPiCf7yrL55B0+p08I1AIZalU=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=mZHstfGKwNLdtkP+MFlV4AosmwIiwrJxNaQMs0UxpU7xUCeLs1W/qlVm8Kn9xR9XXGkMyjnxjiga/jFkkh/YRZLioceELQPH8JI7Ykrl5vmryzg+RkM/a9p7TTP8/pZRzdilHFpgFTm76lfamapexrtC4xTTnbSYgVWfcaBKjs4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=Ptk0ivhN; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="Ptk0ivhN" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1767814636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z1SgIeXwK7eoIrcxdiJuapBod9YS33FgrXRH2Nf3ffM=; b=Ptk0ivhNZ6UGwRHwBOQGRqwSwCmfCfoLASWomi13u3Xtsy2UPKixKOQXQNX1JjDAff1l0r yUu+K2Tt5TTpbP93TSTqCQPV5OpZEW+GOxfW8CyZYbpTdC5XIsj7guZ9jxKyKH5eHIz1x+ BNKBQaTxnk7LLFoLL3cj8I2n2KKg7KTY5NIjvzVHBf3aDlT8RzEzZGURmgHTE2kSwJXDts w+3M0xvi0HyIZWJZZRECSjrC1VSi0gs96rkXmzFB8hnshwnD1VuTlBxFKSVBm7t+UV/bAi i8tW2rF615gdKoZuLdGpnlFmuCYLQ7TV97c0HsbMxafFt8uglnXrtAvQrOqeUA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 07 Jan 2026 20:37:11 +0100 Message-Id: Cc: "Robert Mader" , , , , , , "Matt Roper" Subject: Re: [PATCH v3 0/4] Introduce BACKGROUND_COLOR DRM CRTC property X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Diederik de Haas" , "Cristian Ciocaltea" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Sandy Huang" , =?utf-8?q?Heiko_St=C3=BCbner?= , "Andy Yan" , "Louis Chauvet" , "Haneen Mohammed" , "Melissa Wen" References: <20251118-rk3588-bgcolor-v3-0-a2cc909428ea@collabora.com> In-Reply-To: X-Migadu-Flow: FLOW_OUT On Wed Jan 7, 2026 at 1:18 PM CET, Diederik de Haas wrote: > On Tue Nov 18, 2025 at 12:51 AM CET, Cristian Ciocaltea wrote: >> Some display controllers can be hardware-configured to present non-black >> colors for pixels which are not covered by any plane (or are exposed >> through transparent regions of higher planes). >> ... >> The subsequent patches add background color support to VKMS and the VOP2 >> display controller used in the RK3568, RK3576, and RK3588 Rockchip SoC >> families. > > Cristian provided a helper script which would show a test pattern and > then iterate through setting Red, Green, Blue background color and then > set it back to the original value. > > I first tested this on a Rock 5B (RK3588). > Without this patch set, the background color was Black with every > iteration. But with this patch set, I did see a Red, Green and Blue > background color, after which it was set back to Black. > > diederik@rock5b:~$ grep -E "^Changing prop|^Read BACKGROUND_COLOR" bgcol-= test-bash-user.log > Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 > Changing prop value to: 0xffff00000000ffff > Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff > Changing prop value to 0xffffffff00000000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffffffff00000000 > Changing prop value to 0xffff0000ffff0000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffff0000ffff0000 > Changing prop value to 0xffff00000000ffff > Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff > Changing prop value to: 0xffff000000000000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 > > I then did the same test on a Quartz64-B (RK3566) and that too showed a > Red, Green and Blue background color and then was set back to Black. > > diederik@quartz64b:~$ grep -E "^Changing prop|^Read BACKGROUND_COLOR" bgc= ol-test-bash-user-q64b.log > Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 > Changing prop value to: 0xffff00000000ffff > Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff > Changing prop value to 0xffffffff00000000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffffffff00000000 > Changing prop value to 0xffff0000ffff0000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffff0000ffff0000 > Changing prop value to 0xffff00000000ffff > Read BACKGROUND_COLOR prop (ARGB64): 0xffff00000000ffff > Changing prop value to: 0xffff000000000000 > Read BACKGROUND_COLOR prop (ARGB64): 0xffff000000000000 > > So this patch set does what it is supposed to do, so feel free to add: > > Tested-by: Diederik de Haas I actually tested v4 of this series, so I'll copy-paste the above reply to the correct version this time. > > Cheers, > Diederik > >> Signed-off-by: Cristian Ciocaltea >> --- >> Changes in v3: >> - Added new patches: >> * uapi: Provide DIV_ROUND_CLOSEST() >> * drm/vkms: Support setting custom background color >> - Improved DRM_ARGB64_{PREP|GET}*() helpers by using a conversion ratio >> for better color approximation when dealing with less than 16 bits of >> precision >> - Mentioned the IGT test in the cover letter while documenting the >> validation results; also dropped references to the now useless >> modetest wrapper script and its generated report >> - Rebased series onto latest drm-misc-next >> - Link to v2: https://lore.kernel.org/r/20251013-rk3588-bgcolor-v2-0-25c= c3810ba8c@collabora.com >> >> Changes in v2: >> - Improved uAPI consistency and readability by introducing >> DRM_ARGB64_PREP*() and DRM_ARGB64_GET*() helper macros >> - Updated several code comment sections >> - Referenced the counterpart Weston support in the cover letter >> - Rebased series onto v6.18-rc1 >> - Link to v1: https://lore.kernel.org/r/20250902-rk3588-bgcolor-v1-0-fd9= 7df91d89f@collabora.com >> >> --- >> Cristian Ciocaltea (4): >> uapi: Provide DIV_ROUND_CLOSEST() >> drm: Add CRTC background color property >> drm/vkms: Support setting custom background color >> drm/rockchip: vop2: Support setting custom background color >> >> drivers/gpu/drm/drm_atomic_state_helper.c | 1 + >> drivers/gpu/drm/drm_atomic_uapi.c | 4 ++ >> drivers/gpu/drm/drm_blend.c | 39 ++++++++++++++-- >> drivers/gpu/drm/drm_mode_config.c | 6 +++ >> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 13 +++++- >> drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 4 ++ >> drivers/gpu/drm/vkms/vkms_composer.c | 10 ++++- >> drivers/gpu/drm/vkms/vkms_crtc.c | 3 ++ >> include/drm/drm_blend.h | 4 +- >> include/drm/drm_crtc.h | 12 +++++ >> include/drm/drm_mode_config.h | 5 +++ >> include/linux/math.h | 18 +------- >> include/uapi/drm/drm_mode.h | 67 +++++++++++++++++++++= +++++++ >> include/uapi/linux/const.h | 17 +++++++ >> 14 files changed, 178 insertions(+), 25 deletions(-) >> --- >> base-commit: 92c49b3f4df8f9acfa95551ef38fc00c675319fd >> change-id: 20250829-rk3588-bgcolor-c1a7b9a507bc > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip