From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3070030FF06 for ; Tue, 13 Jan 2026 07:57:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768291032; cv=none; b=XVKScv4Jg3q0CwMFAcJYlPBfoZKtV7tpLmwxsgz+rayvpjd9CyadMSpk0sR8KsBsqUGWYetX1NT1mEPAWHWJIC7SFrzAF/JoCr/4Pk7kaTTke5Hk8zmvOKd36AdBvzNLDkSYzd1//WTruyIAZBYWMWXNzdg073ZAICoBEcZ66iY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768291032; c=relaxed/simple; bh=GUDzicY32nbnMrbPg7AoZisa5lJlzQQBm+pMv6oIcI0=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:To:From: References:In-Reply-To; b=Yh49MRNQa9e9wyUilfETiBi4CMm8oBdrgfsi3iFlqfTPMQwSG0ku4dKdvMhMGpZl1lR8oTOtZ4tJOMgW04WLtlcbZqGIRjL2zcD9zld3KDIS5YPZJ9Y3TBr/vNvsCBB6ISGqffCtlfkc2ztLVlc1JhCKrUCGuvgNV00OGZtYzw0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Q7qJAk+5; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Q7qJAk+5" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 112611A2825 for ; Tue, 13 Jan 2026 07:57:07 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id D9A3160732; Tue, 13 Jan 2026 07:57:06 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 52808103C8245; Tue, 13 Jan 2026 08:57:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1768291026; h=from:subject:date:message-id:to:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=YuizQcmKsxGyB9V2Cl9tfD49wzq70tuj/GsOGkAgtGk=; b=Q7qJAk+5ycmAbTQr35xIgI6FcVkQoiiLv3HCXxuaqYiMsIIG/2zm2wbDeOiOwcvm7I7kPR kN8uvEgcQ4ehx0lLlS1AdIYhj4Bp6jWTtFp/SweMjbY7d5sNkYKrb+a6PEeLBWbY+hY+0E oROpLBWsTg729QvKXVQKDaQcpWC9ceP/hNApWJzOqzQZnPJT5aw8hnxJ4es8NNaXh6lvJu cywb3mFC6zaoYFlS06+bjhy3nGUBBU25+EukMvZ9vmfEUN8q9Np4muhCRzlrGaFFv+90Ph 6wyPr77BKZW8xzo0VUzwzg3a4hX0yOJRyE7twLpjB6J/sCIdioxjNBY7as2CoA== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 13 Jan 2026 08:57:03 +0100 Message-Id: Subject: Re: [PATCH] scripts/decode_stacktrace.sh update usage to show vmlinux is mandatory To: "Jinchao Wang" , "Andrew Morton" , "Matthieu Baerts (NGI0)" , "Carlos Llamas" , From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260112091057.2119227-1-wangjinchao600@gmail.com> In-Reply-To: <20260112091057.2119227-1-wangjinchao600@gmail.com> X-Last-TLS-Session-Version: TLSv1.3 Hello Jinchao, On Mon Jan 12, 2026 at 10:10 AM CET, Jinchao Wang wrote: > The script currently errors out if vmlinux is not provided, but the > usage string implies it is optional. Remove the square brackets to > correctly indicate that is a required argument. > > Signed-off-by: Jinchao Wang Thanks for your patch, but it is not correct. The vmlinux argument is optional when debuginfod info is found: # Can we use debuginfod-find? if type debuginfod-find >/dev/null 2>&1 ; then debuginfod=3D${1-only} fi if [[ $vmlinux =3D=3D "" && -z $debuginfod ]] ; then echo "ERROR! vmlinux image must be specified" >&2 usage exit 1 fi (https://elixir.bootlin.com/linux/v6.19-rc4/source/scripts/decode_stacktrac= e.sh#L65-L74) However I realize improving the error message might make sense, something like: echo "ERROR! vmlinux image must be specified or debuginfo m= ust be accessible" >&2 Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com