Re: [PATCH v8 1/5] rust: devres: style for imports

Zhi Wang
2026-01-15T08:07:27Z

On Tue, 13 Jan 2026 14:25:14 +0000
"Gary Guo" <gary@garyguo.net> wrote:

> On Tue Jan 13, 2026 at 9:22 AM GMT, Zhi Wang wrote:
> > Convert all imports in the devres to use "kernel vertical" style. Drop
> > unnecessary imports covered by prelude::*.
>
> There doesn't appear to be any dropped import?

Yes. It has been done by someone already during the rebase. I will update
this.

>
> Best,
> Gary
>
> >
> > Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
> > Signed-off-by: Zhi Wang <zhiw@nvidia.com>
> > ---
> > rust/kernel/devres.rs | 16 +++++++++++++---
> > 1 file changed, 13 insertions(+), 3 deletions(-)
> >
> > diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs
> > index db02f8b1788d..43089511bf76 100644
> > --- a/rust/kernel/devres.rs
> > +++ b/rust/kernel/devres.rs
> > @@ -254,8 +254,12 @@ pub fn device(&self) -> &Device {
> > /// # Examples
> > ///
> > /// ```no_run
> > - /// # #![cfg(CONFIG_PCI)]
> > - /// # use kernel::{device::Core, devres::Devres, pci};
> > + /// #![cfg(CONFIG_PCI)]
> > + /// use kernel::{
> > + /// device::Core,
> > + /// devres::Devres,
> > + /// pci, //
> > + /// };
> > ///
> > /// fn from_core(dev: &pci::Device<Core>, devres:
> > Devres<pci::Bar<0x4>>) -> Result { /// let bar =
> > devres.access(dev.as_ref())?; @@ -358,7 +362,13 @@ fn
> > register_foreign (dev: &Device<Bound>, data: P) -> Result /// #
> > Examples ///
> > /// ```no_run
> > -/// use kernel::{device::{Bound, Device}, devres};
> > +/// use kernel::{
> > +/// device::{
> > +/// Bound,
> > +/// Device, //
> > +/// },
> > +/// devres, //
> > +/// };
> > ///
> > /// /// Registration of e.g. a class device, IRQ, etc.
> > /// struct Registration;
>