From: "Jesung Yang" <y.j3ms.n@gmail.com>
To: "Tamir Duberstein" <tamird@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] scripts: generate_rust_analyzer: Add compiler_builtins -> core dep
Date: Wed, 14 Jan 2026 18:20:59 +0900 [thread overview]
Message-ID: <DFO79IRELYPB.2V1XQTCGJL5DB@gmail.com> (raw)
In-Reply-To: <20250723-rust-analyzer-pin-init-v1-1-3c6956173c78@kernel.org>
On Thu Jul 24, 2025 at 12:39 AM KST, Tamir Duberstein wrote:
> Add a dependency edge from `compiler_builtins` to `core` to
> `scripts/generate_rust_analyzer.py` to match `rust/Makefile`. This has
> been incorrect since commit 8c4555ccc55c ("scripts: add
> `generate_rust_analyzer.py`")
>
> Signed-off-by: Tamir Duberstein <tamird@kernel.org>
> ---
> scripts/generate_rust_analyzer.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index 7c3ea2b55041..4639a756a932 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -83,7 +83,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs, core_edit
> append_crate(
> "compiler_builtins",
> srctree / "rust" / "compiler_builtins.rs",
> - [],
> + ["core"],
> )
>
> append_crate(
This looks good, but I think
`Fixes: 8c4555ccc55c ("scripts: add `generate_rust_analyzer.py`")` and
`Cc: stable` tags should be specified.
For the change itself,
Reviewed-by: Jesung Yang <y.j3ms.n@gmail.com>
Best regards,
Jesung
next prev parent reply other threads:[~2026-01-14 9:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 15:39 [PATCH 0/3] scripts: generate_rust_analyzer: match rust/Makefile Tamir Duberstein
2025-07-23 15:39 ` [PATCH 1/3] scripts: generate_rust_analyzer: Add compiler_builtins -> core dep Tamir Duberstein
2026-01-14 9:20 ` Jesung Yang [this message]
2025-07-23 15:39 ` [PATCH 2/3] scripts: generate_rust_analyzer: Add pin_init -> compiler_builtins dep Tamir Duberstein
2026-01-14 9:25 ` Jesung Yang
2025-07-23 15:39 ` [PATCH 3/3] scripts: generate_rust_analyzer: Add pin_init_internal deps Tamir Duberstein
2026-01-14 9:26 ` Jesung Yang
2026-01-14 10:29 ` Miguel Ojeda
2026-01-14 10:32 ` Miguel Ojeda
2026-01-14 14:56 ` Tamir Duberstein
2026-01-14 15:47 ` Miguel Ojeda
2026-01-14 10:51 ` Jesung Yang
2026-01-02 15:25 ` [PATCH 0/3] scripts: generate_rust_analyzer: match rust/Makefile Tamir Duberstein
2026-01-02 20:05 ` Benno Lossin
2026-01-02 20:34 ` Tamir Duberstein
2026-01-03 9:58 ` Benno Lossin
2026-01-03 15:19 ` Tamir Duberstein
2026-01-13 18:31 ` Miguel Ojeda
2026-01-15 13:19 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFO79IRELYPB.2V1XQTCGJL5DB@gmail.com \
--to=y.j3ms.n@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox