From: "Danilo Krummrich" <dakr@kernel.org>
To: "Markus Probst" <markus.probst@posteo.de>, <aliceryhl@google.com>
Cc: "Zhi Wang" <zhiw@nvidia.com>, <rust-for-linux@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bhelgaas@google.com>, <kwilczynski@kernel.org>,
<ojeda@kernel.org>, <alex.gaynor@gmail.com>,
<boqun.feng@gmail.com>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
<a.hindborg@kernel.org>, <tmgross@umich.edu>,
<helgaas@kernel.org>, <cjia@nvidia.com>, <smitra@nvidia.com>,
<ankita@nvidia.com>, <aniketa@nvidia.com>, <kwankhede@nvidia.com>,
<targupta@nvidia.com>, <acourbot@nvidia.com>,
<joelagnelf@nvidia.com>, <jhubbard@nvidia.com>,
<zhiwang@kernel.org>, <daniel.almeida@collabora.com>
Subject: Re: [PATCH v9 2/5] rust: io: factor common I/O helpers into Io trait
Date: Fri, 16 Jan 2026 15:44:31 +0100 [thread overview]
Message-ID: <DFQ3EBMAI2N2.O6CY0ZGSL2JH@kernel.org> (raw)
In-Reply-To: <08956b4fe99619064a4424d500837807ba4c92e6.camel@posteo.de>
On Fri Jan 16, 2026 at 2:57 PM CET, Markus Probst wrote:
> On Thu, 2026-01-15 at 23:26 +0200, Zhi Wang wrote:
> How would this work with I2C as a IO backend?
>
> I2C by itself doesn't have 32-bit IO, which the trait requires.
>
> There is
> "byte data" - 8 bit
> "word data" - 16 bit
> "block data" - arbitrary number of bytes (in SMBus limited to 32 bytes.
> Outside of SMBus it could be higher)
You can use a block data transfer to implement 32bit.
> Note that I only require "byte data" for my led driver.
That's fine, not ever driver has to make use of all capabilities.
However, eventually we want to be able to use regmap to implement I/O backends.
For this it could actually become necessary to have separate traits for 8, 16
and 32 bit. But I think this is out of scope for this series, let's leave that
to a subsequent series. We can always split them up when necessary.
next prev parent reply other threads:[~2026-01-16 14:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 21:26 [PATCH v9 0/5] rust: pci: add config space read/write support Zhi Wang
2026-01-15 21:26 ` [PATCH v9 1/5] rust: devres: style for imports Zhi Wang
2026-01-15 21:26 ` [PATCH v9 2/5] rust: io: factor common I/O helpers into Io trait Zhi Wang
2026-01-16 10:44 ` Alice Ryhl
2026-01-16 13:23 ` Danilo Krummrich
2026-01-16 15:23 ` Gary Guo
2026-01-16 15:27 ` Danilo Krummrich
2026-01-17 8:27 ` Zhi Wang
2026-01-16 13:57 ` Markus Probst
2026-01-16 14:44 ` Danilo Krummrich [this message]
2026-01-15 21:26 ` [PATCH v9 3/5] rust: io: factor out MMIO read/write macros Zhi Wang
2026-01-15 21:26 ` [PATCH v9 4/5] rust: pci: add config space read/write support Zhi Wang
2026-01-15 21:26 ` [PATCH v9 5/5] sample: rust: pci: add tests for config space routines Zhi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFQ3EBMAI2N2.O6CY0ZGSL2JH@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=cjia@nvidia.com \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=helgaas@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=kwankhede@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=smitra@nvidia.com \
--cc=targupta@nvidia.com \
--cc=tmgross@umich.edu \
--cc=zhiw@nvidia.com \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox