public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Tzung-Bi Shih" <tzungbi@kernel.org>,
	"Benson Leung" <bleung@chromium.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Linus Walleij" <linusw@kernel.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <shuah@kernel.org>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <chrome-platform@lists.linux.dev>,
	<linux-kselftest@vger.kernel.org>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Simona Vetter" <simona.vetter@ffwll.ch>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Jason Gunthorpe" <jgg@nvidia.com>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v7 0/3] drivers/base: Introduce revocable
Date: Fri, 16 Jan 2026 17:16:58 +0100	[thread overview]
Message-ID: <DFQ5D44A0348.PZJIGPL972N@kernel.org> (raw)
In-Reply-To: <20260116160454.GN30544@pendragon.ideasonboard.com>

On Fri Jan 16, 2026 at 5:04 PM CET, Laurent Pinchart wrote:
> The revocable mechanism isn't the right solution for races between device
> removal and userspace access.

I think you have to differenciate, as it depends on the resource:

If the resource is a device resource (e.g. MMIO resource regions) that must not
be held by the driver after its bound device has been unbound, you have to
revoke the resource from the driver, i.e. you can't just fix it with a reference
count.

Effectively, that's what devres does, it releases the resource when the device
is unbound. Revocable takes care of avoiding a UAF of a subsequent access.

We subsystems that invented subsystem specific implementations for a revocable
mechanism for exactly those cases.

For instance, there is drm_dev_enter() drm_dev_exit() and drm_dev_unplug() which
ultimately does the same things as DRM specific implementation.

If the resource is not a device resource, then revocable is clearly not the
correct solution however.

  reply	other threads:[~2026-01-16 16:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16  8:02 [PATCH v7 0/3] drivers/base: Introduce revocable Tzung-Bi Shih
2026-01-16  8:02 ` [PATCH v7 1/3] revocable: Revocable resource management Tzung-Bi Shih
2026-01-16 15:19   ` Danilo Krummrich
2026-01-16 15:27     ` Bartosz Golaszewski
2026-01-16 15:35       ` Danilo Krummrich
2026-01-16 16:04       ` Laurent Pinchart
2026-01-16 16:41         ` Danilo Krummrich
2026-01-16 18:19           ` Bartosz Golaszewski
2026-01-16 18:24             ` Jason Gunthorpe
2026-01-16 18:31               ` Bartosz Golaszewski
2026-02-04 13:12   ` Bartosz Golaszewski
2026-01-16  8:02 ` [PATCH v7 2/3] revocable: Add Kunit test cases Tzung-Bi Shih
2026-01-16  8:02 ` [PATCH v7 3/3] selftests: revocable: Add kselftest cases Tzung-Bi Shih
2026-01-16 15:17 ` [PATCH v7 0/3] drivers/base: Introduce revocable Greg Kroah-Hartman
2026-01-16 16:04   ` Laurent Pinchart
2026-01-16 16:16     ` Danilo Krummrich [this message]
2026-01-16 16:52       ` Jason Gunthorpe
2026-01-16 17:00         ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFQ5D44A0348.PZJIGPL972N@kernel.org \
    --to=dakr@kernel.org \
    --cc=bleung@chromium.org \
    --cc=brgl@bgdev.pl \
    --cc=chrome-platform@lists.linux.dev \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgg@nvidia.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linusw@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=shuah@kernel.org \
    --cc=simona.vetter@ffwll.ch \
    --cc=tzungbi@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox