From: "Danilo Krummrich" <dakr@kernel.org>
To: "Jason Gunthorpe" <jgg@nvidia.com>
Cc: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Tzung-Bi Shih" <tzungbi@kernel.org>,
"Benson Leung" <bleung@chromium.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Linus Walleij" <linusw@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <shuah@kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <chrome-platform@lists.linux.dev>,
<linux-kselftest@vger.kernel.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Simona Vetter" <simona.vetter@ffwll.ch>,
"Dan Williams" <dan.j.williams@intel.com>,
<linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v7 0/3] drivers/base: Introduce revocable
Date: Fri, 16 Jan 2026 18:00:21 +0100 [thread overview]
Message-ID: <DFQ6ABRP8U2W.GZP8XMBPDO8Q@kernel.org> (raw)
In-Reply-To: <20260116165242.GO961588@nvidia.com>
On Fri Jan 16, 2026 at 5:52 PM CET, Jason Gunthorpe wrote:
> The C code doesn't really work like that, it works on sync teardown
> flows. If you want to write correct C code you need to think about all
> the concurrency the driver has and ensure that removal undoes it
Again, it depends: Sometimes a synchronized teardown is not possible. Iff a
synchronized teardown is not possible by design, this is where revocable is
useful instead.
However, a synchronized teardown should of course always be preferred.
And just to clarify, since you said "the C code": The Rust code follows exactly
the the same principle, prefer synchronized teardown whenever possible.
(The only difference with Rust is that we can always guard device resources and
iff synchronized teardown is ensured through the type system the guard becomes
zero-cost for accesses.)
prev parent reply other threads:[~2026-01-16 17:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 8:02 [PATCH v7 0/3] drivers/base: Introduce revocable Tzung-Bi Shih
2026-01-16 8:02 ` [PATCH v7 1/3] revocable: Revocable resource management Tzung-Bi Shih
2026-01-16 15:19 ` Danilo Krummrich
2026-01-16 15:27 ` Bartosz Golaszewski
2026-01-16 15:35 ` Danilo Krummrich
2026-01-16 16:04 ` Laurent Pinchart
2026-01-16 16:41 ` Danilo Krummrich
2026-01-16 18:19 ` Bartosz Golaszewski
2026-01-16 18:24 ` Jason Gunthorpe
2026-01-16 18:31 ` Bartosz Golaszewski
2026-02-04 13:12 ` Bartosz Golaszewski
2026-01-16 8:02 ` [PATCH v7 2/3] revocable: Add Kunit test cases Tzung-Bi Shih
2026-01-16 8:02 ` [PATCH v7 3/3] selftests: revocable: Add kselftest cases Tzung-Bi Shih
2026-01-16 15:17 ` [PATCH v7 0/3] drivers/base: Introduce revocable Greg Kroah-Hartman
2026-01-16 16:04 ` Laurent Pinchart
2026-01-16 16:16 ` Danilo Krummrich
2026-01-16 16:52 ` Jason Gunthorpe
2026-01-16 17:00 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFQ6ABRP8U2W.GZP8XMBPDO8Q@kernel.org \
--to=dakr@kernel.org \
--cc=bleung@chromium.org \
--cc=brgl@bgdev.pl \
--cc=chrome-platform@lists.linux.dev \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@nvidia.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linusw@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=simona.vetter@ffwll.ch \
--cc=tzungbi@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox