* [PATCH] drivers/base: make devtmpfs_context_ops static
@ 2026-01-15 16:08 dywoq
2026-01-16 14:55 ` Greg KH
2026-01-16 15:42 ` [PATCH v2] " Alexey Suchkov
0 siblings, 2 replies; 6+ messages in thread
From: dywoq @ 2026-01-15 16:08 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, rafael, dakr, dywoq
The devtmpfs_context_ops symbol is only used within devtmpfs.c.
Marking it static removes compiler warnings and limits symbol visibility.
Signed-off-by: dywoq <aleks.koyf@gmail.com>
---
drivers/base/devtmpfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
index 194b44075..748ad3698 100644
--- a/drivers/base/devtmpfs.c
+++ b/drivers/base/devtmpfs.c
@@ -85,7 +85,7 @@ static int devtmpfs_get_tree(struct fs_context *fc)
}
/* Ops are filled in during init depending on underlying shmem or ramfs type */
-struct fs_context_operations devtmpfs_context_ops = {};
+static struct fs_context_operations devtmpfs_context_ops = {};
/* Call the underlying initialization and set to our ops */
static int devtmpfs_init_fs_context(struct fs_context *fc)
--
2.52.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/base: make devtmpfs_context_ops static
2026-01-15 16:08 [PATCH] drivers/base: make devtmpfs_context_ops static dywoq
@ 2026-01-16 14:55 ` Greg KH
2026-01-16 19:09 ` Alexey Suchkov
2026-01-16 15:42 ` [PATCH v2] " Alexey Suchkov
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2026-01-16 14:55 UTC (permalink / raw)
To: dywoq; +Cc: linux-kernel, rafael, dakr
On Thu, Jan 15, 2026 at 07:08:53PM +0300, dywoq wrote:
> The devtmpfs_context_ops symbol is only used within devtmpfs.c.
> Marking it static removes compiler warnings and limits symbol visibility.
>
> Signed-off-by: dywoq <aleks.koyf@gmail.com>
We need a real name here, thanks!
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] drivers/base: make devtmpfs_context_ops static
2026-01-15 16:08 [PATCH] drivers/base: make devtmpfs_context_ops static dywoq
2026-01-16 14:55 ` Greg KH
@ 2026-01-16 15:42 ` Alexey Suchkov
2026-01-16 23:12 ` Danilo Krummrich
1 sibling, 1 reply; 6+ messages in thread
From: Alexey Suchkov @ 2026-01-16 15:42 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, dakr, rafael, Alexey Suchkov
The devtmpfs_context_ops symbol is only used within devtmpfs.c.
Marking it static removes compiler warnings and limits symbol visibility.
Changes since v1:
- Use real name in From and Signed-off-by
Signed-off-by: Alexey Suchkov <aleks.koyf@gmail.com>
---
drivers/base/devtmpfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
index 194b44075..748ad3698 100644
--- a/drivers/base/devtmpfs.c
+++ b/drivers/base/devtmpfs.c
@@ -85,7 +85,7 @@ static int devtmpfs_get_tree(struct fs_context *fc)
}
/* Ops are filled in during init depending on underlying shmem or ramfs type */
-struct fs_context_operations devtmpfs_context_ops = {};
+static struct fs_context_operations devtmpfs_context_ops = {};
/* Call the underlying initialization and set to our ops */
static int devtmpfs_init_fs_context(struct fs_context *fc)
--
2.52.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/base: make devtmpfs_context_ops static
2026-01-16 14:55 ` Greg KH
@ 2026-01-16 19:09 ` Alexey Suchkov
0 siblings, 0 replies; 6+ messages in thread
From: Alexey Suchkov @ 2026-01-16 19:09 UTC (permalink / raw)
To: gregkh; +Cc: aleks.koyf, dakr, linux-kernel, rafael
Hi Greg,
>
> We need a real name here, thanks!
>
I updated the commit message to include a full real name in v2.
Let me know if anything else is needed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drivers/base: make devtmpfs_context_ops static
2026-01-16 15:42 ` [PATCH v2] " Alexey Suchkov
@ 2026-01-16 23:12 ` Danilo Krummrich
2026-01-17 6:36 ` [PATCH] " Alexey Suchkov
0 siblings, 1 reply; 6+ messages in thread
From: Danilo Krummrich @ 2026-01-16 23:12 UTC (permalink / raw)
To: Alexey Suchkov; +Cc: linux-kernel, gregkh, rafael
On Fri Jan 16, 2026 at 4:42 PM CET, Alexey Suchkov wrote:
> The devtmpfs_context_ops symbol is only used within devtmpfs.c.
> Marking it static removes compiler warnings and limits symbol visibility.
>
> Changes since v1:
> - Use real name in From and Signed-off-by
>
> Signed-off-by: Alexey Suchkov <aleks.koyf@gmail.com>
This is already fixed by [1]. Note that the patch was already sent at Jan 8, but
due to a typo didn't make it to the list.
[1] https://patch.msgid.link/20260116150745.1330145-1-ben.dooks@codethink.co.uk
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers/base: make devtmpfs_context_ops static
2026-01-16 23:12 ` Danilo Krummrich
@ 2026-01-17 6:36 ` Alexey Suchkov
0 siblings, 0 replies; 6+ messages in thread
From: Alexey Suchkov @ 2026-01-17 6:36 UTC (permalink / raw)
To: dakr; +Cc: aleks.koyf, gregkh, linux-kernel, rafael
Hi Danilo,
> This is already fixed by [1]. Note that the patch was already sent at Jan 8, but
> due to a typo didn't make it to the list.
Thanks for the pointer. Since this is already fixed by another patch,
I'll drop mine. Thank you!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-01-17 6:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-15 16:08 [PATCH] drivers/base: make devtmpfs_context_ops static dywoq
2026-01-16 14:55 ` Greg KH
2026-01-16 19:09 ` Alexey Suchkov
2026-01-16 15:42 ` [PATCH v2] " Alexey Suchkov
2026-01-16 23:12 ` Danilo Krummrich
2026-01-17 6:36 ` [PATCH] " Alexey Suchkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox