From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92445247291 for ; Sat, 17 Jan 2026 19:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768679072; cv=none; b=LTlA0dTWnxlLnPhoIrLC2ffERdGi+XmbMNQxl3qkCBDa+fvyYfZRGG7FtxPxEpihDDvR+dUDTIAGzpPZK/wgG+icVpB8TVTGcP40cdUlsKD+d8Gmnp05uk0pqAAcdrm2mTjmdxF7nGITJRHsQ9grot+8A+d5mfzgFc07uTaYyr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768679072; c=relaxed/simple; bh=xkKytNjeVcjDL10/GqrC/ZAsjwWotwsWzGLKnH3NAuc=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=qj6g/XwcNSCFPGSU/Q9PK1AFOQU0yXPebbxzVdhsWhXnWJuMuFtinLhS/C89HYOFxv6FieWsWYdonlql/+9aP+lyY0KYtT9kTtBbem9TSL7EIKxKhvw5VYrHsqMcVW/cZMXbPO7gyvQ4xf/waNzZgFkL3+RylCoq9x/2zfUCkkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WuWYeHx2; arc=none smtp.client-ip=209.85.217.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WuWYeHx2" Received: by mail-vs1-f48.google.com with SMTP id ada2fe7eead31-5ee9fa419f5so708499137.3 for ; Sat, 17 Jan 2026 11:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768679069; x=1769283869; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=u1uCAAMUi0Dl9Xk8gsU5DOI/xVq90HWLTJ/j/86WebA=; b=WuWYeHx2t0UMihtmfyebMkrK3vAFhMp8+3Egb3geZqgHHiXDCkYiD5zfQ6MWrGBou/ 7NHs8LJr432/WaGSJBxySFrl5WnZuED6RyI2Vm26Smj+ESykBYKvitk3tvkUmwrU83MQ KykAJWAm9lK2GtSMUlTW6uImzSXsHUkQ1G+YBf8sOzzE5sPJZkWCysA1uNnDc3sxGfiR Q+vSsGlRk9NSZWMrUPN+5L5bPutVDF9EyAZQKSU8tY/Il85dipU8E0zcUUY9NICSfdo4 oNyBcTnoGIHL2YwDo1ggzMBIIdteu/ZYDsoxM+3N312Aw9kKRTNgJxvhHr05yDyxSBGX FrJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768679069; x=1769283869; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=u1uCAAMUi0Dl9Xk8gsU5DOI/xVq90HWLTJ/j/86WebA=; b=aomV6IBqNypZntF3VaWYGmHagxo2HBxKmzT8dRG8qUUtkpunPNBZoXGsppTHbRSPXi QeFDq0x+QHJ/5Jd+Ot9Ls8yuqgMmiLHrMKL1n9n5eO57xVHL4P54NCnSHguApl0MqT76 O7rQCTEUbohWWhyvep2VaRNjhZVQjlGOFP5pkKnSR9PCqjFjT5UnuvuO/HtQJVdg0hMY xb0nuEVHzxpzXnFueO3EzOeMKLD8O5G3ULtYbbmpoJkXTh6NI9b0KjBd4erdCK2er/ez wGgP7vIgb/VqRkFUkiy6u+r+sn76dBvSPR8wh1Ep3bYnEFJ6UKNcm8Rd+Yg9dl14IgL3 ldig== X-Forwarded-Encrypted: i=1; AJvYcCWyHDhuuB8CNZMhjy7C/08L27P8+REaH81NDwqyCYKdJqArYH6Uz/4D74LySE4DA++e7rNQeUgu61naadM=@vger.kernel.org X-Gm-Message-State: AOJu0YzpEYjYaQML+TZeM7OaWVesEPQxHI5nFjBwx30Vov0JZzwmOZ/D d7JgVj7CZORSwATNahj00YDt9Qke4pV/x8HGq3uMHQdoastsgw8dBUTf X-Gm-Gg: AY/fxX5wIOPt9hu8/D0UKpfAwlaq2Di4jl8azaGLRWfQ7ovofZjYGtrrgQgdslDOKBK RWGJKvqWrCWWQ/kroEaBM/rBSJrKvW/gnTiWejADgOXqKldAPO4wmkUmw6YkGyTIpgGCFVxFIb2 h3ysWSdF60Jw/jCZ3zfR5pmZBHk3zuW4PlfUljUBJEjwwg80Hisl3g3y5pqbvL7glWsVJkd4TML QE7ZITl2MMyT4zQ9ufmNRAiTk/osRqFxIM5pFgEgbtc7n4hlIFW9e5dR6yWLg3ursHZTXGRFtLv YJgiDnGGRC8djxqiQXoAaEU96BPN3De2DEkOnykPMDQw6mdHy3JEy9ADMbeJdBn9khqthgbTt8i MtC61BDT0VmGobcSwJSO6Xj+dihTpAD27dDI0YIg1wDVFZ4nTTB6e4gJHZp0VHOuAe880ByLiZH tYgw== X-Received: by 2002:a05:6102:f10:b0:5ee:a309:6684 with SMTP id ada2fe7eead31-5f1a4dc26femr2032982137.10.1768679069122; Sat, 17 Jan 2026 11:44:29 -0800 (PST) Received: from localhost ([2800:bf0:82:11a2:7ac4:1f2:947b:2b6]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-947d04377bfsm1854349241.10.2026.01.17.11.44.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jan 2026 11:44:28 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 17 Jan 2026 14:44:21 -0500 Message-Id: Subject: Re: [PATCH v3 0/7] iio: core: Introduce cleanup.h support for mode locks From: "Kurt Borja" To: "David Lechner" , "Kurt Borja" , "Andy Shevchenko" , "Lars-Peter Clausen" , "Michael Hennerich" , "Jonathan Cameron" , "Benson Leung" , "Antoniu Miclaus" , "Gwendal Grignou" , "Shrikant Raskar" , "Per-Daniel Olsson" Cc: =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , "Guenter Roeck" , "Jonathan Cameron" , , , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260106-lock-impr-v3-0-1db909b192c0@gmail.com> <4e77ebef-07b3-49ae-9d53-d24616569a74@baylibre.com> In-Reply-To: <4e77ebef-07b3-49ae-9d53-d24616569a74@baylibre.com> On Fri Jan 16, 2026 at 5:08 PM -05, David Lechner wrote: > On 1/6/26 2:06 AM, Kurt Borja wrote: >> Hi, >>=20 >> In a recent driver review discussion [1], Andy Shevchenko suggested we >> add cleanup.h support for the lock API: >>=20 >> iio_device_claim_{direct,buffer_mode}(). >>=20 >> Which would allow some nice code simplification in many places. Some >> examples are given as patches, but the last two are the biggest >> differences. >>=20 >> In this version I dropped the RFC tag, as the general feeling is to go >> through with this after some modifications. Main one is the addition of >> IIO_DEV_ACQUIRE_{BUFFER,CLAIM}_MODE() wrappers to avoid drivers using >> the guard classes directly. I also added comments on the forbidden ways >> to use this API but I definitely still take suggestions on this. >>=20 >> For now I dropped iio_device_claim_buffer_mode() rename, as this point >> is still being discussed. My suggestion based on the RFC discussion is >> to do it, but in a separate patch (using coccinelle) and while we're at >> it rename the whole API like this: >>=20 >> iio_dev_mode_lock() >> iio_dev_mode_direct_trylock() >> iio_dev_mode_buffer_trylock() >> iio_dev_mode_unlock() >>=20 >> Let me know what you think and thanks for taking a look! >>=20 >> Signed-off-by: Kurt Borja >> --- > Like Jonathan, I just had a few minor suggestions, but overall: > > Reviewed-by: David Lechner Hi David, I'll add your remarks in the next version. Thanks for all the feedback! --=20 Thanks, ~ Kurt