From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDF363803C2 for ; Mon, 19 Jan 2026 15:52:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768837948; cv=none; b=ggbkn7bSScMz4MQ30lQpiXaetJyjsyxn5Dp+nQhD1/cbG4o2yJNuwrHm1LO0QhvwYJ+9y9Z56EmoR8NKZ5ed/5oJ7DNU4S0dFAgRk3FNgBQ4azMyLzCgtgWmhdAlyQfpa1LUzy0DqppiB4kJvcJm6D7H3BLn4eM7/BGexsj17l8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768837948; c=relaxed/simple; bh=hmFWkaNjPJg0ioPLpbxNfZVs6zemNfl3UQ9lpEvUopw=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=tu53WNVbCSkg+zBCJ/C6uuhvLFyfzdD01pg0L3IcKHqmn5eW0ola6Mhmhmsj4ayPjW0QvhUUt2LDCkdz45I03ReIhPC0GT2It/iB/PXUDP9T/SBfki9ntkhwaFsES22bhqlGVnIrYa93+5k/D/f0O5ACazer2aDJvr7jtP6BWs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=sDA2oJMU; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="sDA2oJMU" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b7cf4a975d2so778472766b.2 for ; Mon, 19 Jan 2026 07:52:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1768837945; x=1769442745; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ydzLNmqrNw79cznaWxcj/vU4qCKsfInZqdkzuOLukEY=; b=sDA2oJMUN0WLSPzOzyP+whoU+Mfyqsz4btnURPSZZszzL79YJPr4lNqtAkhuOJXziZ iHbq40ya5d6jt2cTKgmU1xrRvwbJmIgvWL/01iT5A35P1AL6nJaA6xgxk73Q4v6nwP/w poGBTBfFFYf7x3DKlQUe0XFF8FQEADES5r3dypoX2FPoiGVD7f+x1m5cHbLUtOwLS1vX c0zBIELGJDlESedyPaOqi9mLP9psfWEt4QA+4SQbv4AxKyDwzBbs3vo1wkzayb4OsMKK fXm+0X5g2fMKROOZUKteRUeDgg5VNAz9iKes7Ak9pz8SNLU7f7k62HdethtIA0Oh76uF 6xLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768837945; x=1769442745; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ydzLNmqrNw79cznaWxcj/vU4qCKsfInZqdkzuOLukEY=; b=Lvf5iO2kQpgHkwOJv1+pHNzzMFxLNUOOob6Z3j7JtVbmWNd8R+vu/OLq7LnWWkIDvG KWLbpgEfLSLAgdVhnFt/wOCwipw3uaS/tHupV0icR+pz3f8+qxFH2ySEdKLqcxBl+1bI S2rkODETMew+yyJ63zvQ2Lebdqffx3Gjba3ZtcL9dy597U5YgL9XbFq4olR/x5HlNFPh grDGMRm9PZ5uHUjS/6WReeuTRfbegrqrkypuungHquwR1VMrI8KUntc8eDjyRHmpjtoG K6hNBKJImQHrTc3738lX0cAs5ZbS099JBXLSqrizxz4PtFh387emSn7Sx4KryOmBuOqi 6MfQ== X-Forwarded-Encrypted: i=1; AJvYcCVbRhVzSgGlbfUNRo6bIPwLW3NDt9sDnTsAAO+Jr9+X8ZEDqC1ZthAyw15J7yLqwGL34JN1wAdogUQMf7U=@vger.kernel.org X-Gm-Message-State: AOJu0YxM8hNWkAmX4Bd4BoaGcSK9pvKQIMleK+sR125Dd6pIMoMLlbVZ 9WAdihETEUiROJ2EiMUkEiBhsiIuRenT1QI0BzQK8l1wZZQzoI8jfrnLcx3DIBKpE7c= X-Gm-Gg: AY/fxX5reeD0G/gqS2eG0G3TU/uXiqJ3g2Ar3Vj+72IkyD9mYdIepPmJcfFwQHFADuZ RiA8/ou1/xJORR6m5iNwqjX/+qnRewN1eihxBWciTcOJF5n0Cj5a8nng19juTs5h6GLcFvr3l3S XjHDVJDbdSiK5RDi/66v2Xhaxu572hnUPghip9B4mrSsl2kdcSwFwQjLUt9ZxHbKOotqygTDPN5 rYn7+q8+sXK/7igGAeYhL/kBjpnx+f7p3MLMXWhe0qIAbgGmyF2clZGhtacm2qbeCQopD3GAyhL c6+RMknT+nbmfl84PvvQJiq7/Hv7Vtb1kRQSbl68ACvwDlvHLeq+KfwKvawC0TY4hUgH0vsSFO+ Oxw5WmD1dSSV9DwVAAr4tOJzVGMvfpO+Nxuzo0RDBj6EfxZYsMPXDR673dYN0ogpsBT6+Fv4oEl K0C82l+tixwsl6nAwFxNLg9zc6IHQHBeIBWFCZzjy1cSgtkU+x8SC+4GwIQ/iaZaailDA= X-Received: by 2002:a17:906:ef05:b0:b87:1064:4ea1 with SMTP id a640c23a62f3a-b879302d388mr921496066b.65.1768837944673; Mon, 19 Jan 2026 07:52:24 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b87959c9fbbsm1159645266b.38.2026.01.19.07.52.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 07:52:24 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 19 Jan 2026 16:52:23 +0100 Message-Id: Subject: Re: [PATCH] arm64: dts: qcom: milos-fairphone-fp6: Add Hall Effect sensor From: "Luca Weiss" To: "Konrad Dybcio" , "Luca Weiss" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260116-fp6-hall-sensor-v1-1-69275c6bd809@fairphone.com> <3a17f2e5-0724-4d70-bd22-1e612142b3e8@oss.qualcomm.com> In-Reply-To: <3a17f2e5-0724-4d70-bd22-1e612142b3e8@oss.qualcomm.com> On Mon Jan 19, 2026 at 3:41 PM CET, Konrad Dybcio wrote: > On 1/16/26 3:22 PM, Luca Weiss wrote: >> Add a node for the Hall Effect sensor, used to detect whether the Flip >> Cover is closed or not. >>=20 >> The sensor is powered through vreg_l10b, so let's put a >> regulator-always-on on that to make sure the sensor gets power. > > Is there anything else on L10B? Can we turn it off if the hall sensor > is e.g. user-disabled? It's the voltage source for pull-up of sensor I2C bus (so ADSP-managed?), DVDD for amplifiers and VDD for a most sensors like the gyro. So realistically, it'll probably be (nearly) always on anyways. And I don't want to shave another yak by adding vdd support to gpio-keys... Regards Luca > > Konrad > >>=20 >> Signed-off-by: Luca Weiss >> --- >> arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >>=20 >> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm= 64/boot/dts/qcom/milos-fairphone-fp6.dts >> index 7629ceddde2a..98b3fc654206 100644 >> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >> @@ -32,6 +32,16 @@ gpio-keys { >> pinctrl-0 =3D <&volume_up_default>; >> pinctrl-names =3D "default"; >> =20 >> + /* Powered by the always-on vreg_l10b */ >> + event-hall-sensor { >> + label =3D "Hall Effect Sensor"; >> + gpios =3D <&tlmm 70 GPIO_ACTIVE_LOW>; >> + linux,input-type =3D ; >> + linux,code =3D ; >> + linux,can-disable; >> + wakeup-source; >> + }; >> + >> key-volume-up { >> label =3D "Volume Up"; >> gpios =3D <&pm7550_gpios 6 GPIO_ACTIVE_LOW>; >> @@ -316,6 +326,8 @@ vreg_l10b: ldo10 { >> regulator-min-microvolt =3D <1800000>; >> regulator-max-microvolt =3D <1800000>; >> regulator-initial-mode =3D ; >> + /* Hall sensor VDD */ >> + regulator-always-on; >> }; >> =20 >> vreg_l11b: ldo11 { >>=20 >> --- >> base-commit: ef1c7b875741bef0ff37ae8ab8a9aaf407dc141c >> change-id: 20260116-fp6-hall-sensor-1049f2f872ac >>=20 >> Best regards,