From: "Danilo Krummrich" <dakr@kernel.org>
To: "Daniel Almeida" <daniel.almeida@collabora.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/4] rust: drm: dispatch delayed work items to the private data
Date: Tue, 20 Jan 2026 12:14:33 +0100 [thread overview]
Message-ID: <DFTDFR0943NX.3RTHNQURC11XQ@kernel.org> (raw)
In-Reply-To: <20260115-aref-workitem-v1-4-9883e00f0509@collabora.com>
On Fri Jan 16, 2026 at 1:36 AM CET, Daniel Almeida wrote:
> +// SAFETY: Our `HasWork<T, ID>` implementation returns a `work_struct` that is
> +// stored in the `work` field of a `delayed_work` with the same access rules as
> +// the `work_struct` owing to the bound on `T::Data: HasDelayedWork<Device<T>,
> +// ID>`, which requires that `T::Data::raw_get_work` return a `work_struct` that
> +// is inside a `delayed_work`.
> +unsafe impl<T, const ID: u64> HasDelayedWork<Device<T>, ID> for Device<T>
> +where
> + T: drm::Driver,
> + T::Data: HasDelayedWork<Device<T>, ID>,
> +{
> +}
What do you intend to do within work that is queued for a DRM device? I assume
you have to access bus device resources?
Also, it would be nice to see how this is used in a driver. Can you please add a
patch for Tyr to the series?
next prev parent reply other threads:[~2026-01-20 11:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 0:35 [PATCH 0/4] rust: Add ARef support for work items Daniel Almeida
2026-01-16 0:35 ` [PATCH 1/4] rust: workqueue: add support for ARef<T> Daniel Almeida
2026-01-16 0:35 ` [PATCH 2/4] rust: drm: dispatch work items to the private data Daniel Almeida
2026-01-20 11:13 ` Danilo Krummrich
2026-01-16 0:35 ` [PATCH 3/4] rust: workqueue: add delayed work support for ARef<T> Daniel Almeida
2026-01-16 0:36 ` [PATCH 4/4] rust: drm: dispatch delayed work items to the private data Daniel Almeida
2026-01-20 11:14 ` Danilo Krummrich [this message]
2026-01-20 14:32 ` Daniel Almeida
2026-01-20 10:37 ` [PATCH 0/4] rust: Add ARef support for work items Alice Ryhl
2026-01-20 14:41 ` Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFTDFR0943NX.3RTHNQURC11XQ@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox