From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8F4D477E32 for ; Wed, 21 Jan 2026 08:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768983266; cv=none; b=X14b+IeOUHWdVpIcD7Ci7Ym+5cjwdl6pn/Biw8+5fuh9tjKrmHYPNSlRih4i2OgRPkkjEIGWecPUj4yxhu7Lm64HRafMub5aBacw6R46p6UfLhNywksdW29ATqUWFU205Ii16du6xDUqO6eJ9T8W+LYQDyPs0SuqS6ANxwn/3C0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768983266; c=relaxed/simple; bh=VUNr7lFUgeJlCcWWkvKVqUs0F9SMcihjWUtl64kLz60=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=rHD61D36/VEWilvvjnE8Ycpl/ALzNQftjT+o5u1pXdHMvNM9eQYNQxKjOak7ZPlx98yDNW44D9pf1vQQG9NmvdiZLqRNHBI6jCRuy34mRify3XntzgkBfkWpHGCzk95RTKSw53wMnP/7UiWChkgvaTFXdY+bTo5fB90Q7Y7tFyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com; spf=pass smtp.mailfrom=cknow-tech.com; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b=IHDluf3r; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow-tech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="IHDluf3r" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1768983252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yfisx39MoKyL9c3tUxQTaTOyIEsGPjfK03MuLUniLRw=; b=IHDluf3rviNEt+6PbCXoDsnMOzMhg8Q409a5vnXpMoZ7pLPnF52xoRtpuHQmx5bqU6huWm EeTvW4Q2PdpEic7wbdZLwVvj18ZhLDbsEO0tqI3cqjGSO3Hq6phrfPXYjIjzb11HvW7FTO iqy8bPi3hQcyLWztQrH/XsHtdOU6hauOBk6R0YppA1h2NeQKtGc+dgxVgMtInY4OFlREGH xWgfgixUu2uQzUKl5k7HquVn/UtfI02RpfpqgNDWTtBtR0qMCDeKNkom2rWklTa81z3lEA 8MS8e+cuS+3kM/fVMrlYlaUGsf5MYM4gAdnUli2Lah2z1a8WAhAc0cC6lOouxw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 21 Jan 2026 09:14:05 +0100 Message-Id: To: "Chaoyi Chen" , "Andrew Lunn" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" , "Alexey Charkov" , "Shawn Lin" , "Sebastian Reichel" , "Chaoyi Chen" , "Andy Yan" , "Nicolas Frattaroli" , "Detlev Casanova" , "Stephen Chen" Cc: , , , Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Change gmac phy-mode to rgmii-id for rk3576 evb1 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" References: <20260121031548.402-1-kernel@airkyi.com> <20260121031548.402-2-kernel@airkyi.com> In-Reply-To: <20260121031548.402-2-kernel@airkyi.com> X-Migadu-Flow: FLOW_OUT On Wed Jan 21, 2026 at 4:15 AM CET, Chaoyi Chen wrote: > From: Chaoyi Chen > > According to the description in the net documentation, PHY modes > "rgmii", "rgmii-rxid" and "rgmii-txid" modes require the clock signal > to be delayed on the PCB. > > The Rockchip platform has long used the above mentioned PHY modes and > private delay prop to describe the internal IO delay settings of the > chip, which is inconsistent with what is described in the documentation. > > Let's describe this part of the delay in the PHY and use the more > reasonable "rgmii-id" mode. > > Signed-off-by: Chaoyi Chen > --- > arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts b/arch/arm6= 4/boot/dts/rockchip/rk3576-evb1-v10.dts > index c5584c26db52..3ee76bafafb5 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts > @@ -266,7 +266,7 @@ &combphy1_psu { > =20 > &gmac0 { > clock_in_out =3D "output"; > - phy-mode =3D "rgmii-rxid"; > + phy-mode =3D "rgmii-id"; > phy-handle =3D <&rgmii_phy0>; > pinctrl-names =3D "default"; > pinctrl-0 =3D <ð0m0_miim > @@ -275,14 +275,13 @@ ð0m0_rx_bus2 > ð0m0_rgmii_clk > ð0m0_rgmii_bus > ðm0_clk0_25m_out>; > - tx_delay =3D <0x21>; This being '0x21' (not '0x20') ... > status =3D "okay"; > }; > =20 > &gmac1 { > clock_in_out =3D "output"; > phy-handle =3D <&rgmii_phy1>; > - phy-mode =3D "rgmii-rxid"; > + phy-mode =3D "rgmii-id"; > pinctrl-names =3D "default"; > pinctrl-0 =3D <ð1m0_miim > ð1m0_tx_bus2 > @@ -290,7 +289,6 @@ ð1m0_rx_bus2 > ð1m0_rgmii_clk > ð1m0_rgmii_bus > ðm0_clk1_25m_out>; > - tx_delay =3D <0x20>; > status =3D "okay"; > }; > =20 > @@ -721,6 +719,7 @@ rgmii_phy0: ethernet-phy@1 { > reset-assert-us =3D <20000>; > reset-deassert-us =3D <100000>; > reset-gpios =3D <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>; > + tx-internal-delay-ps =3D <1950>; ... shouldn't this be higher? 0.0579 * 0x21 + 0.105 =3D 2.0157 (not sure how the rounding goes) Cheers, Diederik > }; > }; > =20 > @@ -737,6 +736,7 @@ rgmii_phy1: ethernet-phy@1 { > reset-assert-us =3D <20000>; > reset-deassert-us =3D <100000>; > reset-gpios =3D <&gpio3 RK_PA3 GPIO_ACTIVE_LOW>; > + tx-internal-delay-ps =3D <1950>; > }; > }; > =20