From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6843E360748 for ; Thu, 22 Jan 2026 22:27:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769120856; cv=none; b=Z1Grpv6lrt5EDyCogBRj93LFfO1lz/tDu6KJhiqR1qaDoQGKc2aOa2dAVTnwf8jl5dUKCbr7GbYpBaNNurEJV2B+aOzLy/zNauA2cREoe7kfcC6OaDPK1ovobj6FiZqhCsEs6Vs3DHfU3leQx/CF9nwyc7GkHcQwElFtjqoXhCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769120856; c=relaxed/simple; bh=ZssbIbYyhJxGAI1RfQdyrNCll8e8m/BvfBwg2KD5tsk=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=p50/lFdspnEWJsryERo5Fi1KJYd6gOYxggC6RjV9svzzUKpZ6Mh9noLl+sEoACtrDt/NELqK0gri1rnZbcf+RXMYe3vQ7rQADdGc93e8bza+yEgtAPEAY4kXzMiZfOLT6Ave1CtAQiVf+RLd70+DJot5xeYhdLwHGg+B7bd0jbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F76yTzCR; arc=none smtp.client-ip=209.85.222.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F76yTzCR" Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-948029fb1f2so400618241.0 for ; Thu, 22 Jan 2026 14:27:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769120850; x=1769725650; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UklvachexUu0ZUTLfggsuMCR/kjk6daLXKn7WqUk/vU=; b=F76yTzCRId1vEjkuxLVoOnQn0O6Lo4UPCKNd3zmsqJTSTpgIFDVzzZALxhojegA0M/ WSzCqu6uAFa8vPFrKJhKSSty2CYVFQRsvIpLY9qJOCiamMNqH+t9OBFC7JsjsepBeLcM mmmkcZILfNdkI5HQ8Udb5zDvn0nfY4xNkZ0id0or4ik0gFofTDVp+O0F7CUiMStLQn96 eKvMjWoLWYNUzRUrfF5g7wKaFUhbNYhQI5YTI9G505fm30dHG9u9D7T/8qWdwPmXGMIN /r5xjC/F/B9NFiJv++2ePOj5OrLetjJlzhRaulUPzxKaokBsDCpiS3V/ch5jx0L71KGC vOfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769120850; x=1769725650; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UklvachexUu0ZUTLfggsuMCR/kjk6daLXKn7WqUk/vU=; b=EJ8jSJGuT+ztucV8MeiIrnahVxpsi8szJDFUgk1XSytzK6PmiwxIxFXu3pbNwl8iHB WsZdaAnfXp1KrHmuAvDDcJ+lviPn9NWqj807ZwkMZqjQhe1gIf6UJgSGGOINMqfITMWG aUUQb6pj6UdGt8qzLbf9Y1kui5XG/lWk9G7iMKGI6MR1AcfJ3vnOiWgFp/KyGH798MlT 0fO6P4wf13H/KqJpdAgR12AK46jN46nloV3t2IXITZUJTqmRn4jX881jJ4qnaPwixgPJ dlpeOqpg8abpa1bPIyk0A+ZJGBvQXdjFu/vChWmSmTiENcbS4yTqLzdGwxj2SHSa5md1 jlMQ== X-Forwarded-Encrypted: i=1; AJvYcCVDVpKz1mT/K2ClJozKYX9EN+2BgiRkfgoF3bYdOeYvnPo7cMUT1/8kSv9ZNJjZI431P5QJGqFygLvyQ4Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxVsR4vSXdfcMaRi7fMkZhewutLd80At0tLtv6fXWDPpE4Ja5+J punYsNtfbNXjI6T/3X0ZKSNtAKoA+IPEinp0RwMM3zN8cKA7zoCjORY1 X-Gm-Gg: AZuq6aJ+7K5RPP6JJpCzht9G14flhyhlQz1Yi0LkN/+8F4uEGC+C4uH9N03OZXq2nKA 4I+uxmu0EInCXRIDWDiQCqRHaVKNwKPV10BR07IwDxjh9HDiYoLOLymVaVxYKp2d6N/DzQflORv VX8Mrek2oJfu/DQdRZ+LtBUGZEDkVUuq6ysYcBZTG6UbBdtMixsqffd/EUCQbJt9fUDyIPE9UdK PBMTDIvywLGU2PwzZUsNWwy39KLHAmF08590QV/5t45w87DRhO/tMrbPpR9xEv0RXVzEMe6fCaL jJpwbGqvlLyV3/1O0aHtDgcSLJf79EHyHriOxrBECqsNDgn3LdkNrHunnSuljkB5ZARj+opN9Sw dYux1KIwauJ+iUXnCaUG5MtB5BL0yuT8f8KgdwYuC9FdSvlg99TCVleLjVxTVjw6B1BN/BgcZLC gzn3N/95k= X-Received: by 2002:a05:6102:508e:b0:5ef:7221:aaa1 with SMTP id ada2fe7eead31-5f54bc6f7bcmr368453137.27.1769120849596; Thu, 22 Jan 2026 14:27:29 -0800 (PST) Received: from localhost ([2800:bf0:4580:3149:c903:2904:3cc3:8b4c]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-9482e37e7acsm100671241.13.2026.01.22.14.27.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 14:27:29 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 22 Jan 2026 17:27:26 -0500 Message-Id: Cc: "Andy Shevchenko" , "Lars-Peter Clausen" , "Michael Hennerich" , "Benson Leung" , "Antoniu Miclaus" , "Gwendal Grignou" , "Shrikant Raskar" , "Per-Daniel Olsson" , "David Lechner" , =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , "Guenter Roeck" , "Jonathan Cameron" , , , Subject: Re: [PATCH v5 0/7] iio: core: Introduce cleanup.h support for mode locks From: "Kurt Borja" To: "Jonathan Cameron" , "Kurt Borja" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260120-lock-impr-v5-0-d4d22347041f@gmail.com> <20260122191648.2c10cdf6@jic23-huawei> In-Reply-To: <20260122191648.2c10cdf6@jic23-huawei> On Thu Jan 22, 2026 at 2:16 PM -05, Jonathan Cameron wrote: > On Tue, 20 Jan 2026 01:20:40 -0500 > Kurt Borja wrote: > >> Hi, >>=20 >> In a recent driver review discussion [1], Andy Shevchenko suggested we >> add cleanup.h support for the lock API: >>=20 >> iio_device_claim_{direct,buffer_mode}(). >>=20 >> Which would allow some nice code simplification in many places. Some >> examples are given as patches, but the last two are the biggest >> differences. >>=20 >> In this version I dropped the RFC tag, as the general feeling is to go >> through with this after some modifications. Main one is the addition of >> IIO_DEV_ACQUIRE_{BUFFER,CLAIM}_MODE() wrappers to avoid drivers using >> the guard classes directly. I also added comments on the forbidden ways >> to use this API but I definitely still take suggestions on this. >>=20 >> For now I dropped iio_device_claim_buffer_mode() rename, as this point >> is still being discussed. My suggestion based on the RFC discussion is >> to do it, but in a separate patch (using coccinelle) and while we're at >> it rename the whole API like this: >>=20 >> iio_dev_mode_lock() >> iio_dev_mode_direct_trylock() >> iio_dev_mode_buffer_trylock() >> iio_dev_mode_unlock() >>=20 >> Let me know what you think and thanks for taking a look! >>=20 >> Signed-off-by: Kurt Borja > I've queued this up. For now it'll just be pushed out on the testing bran= ch. > Hopefully the new noise from sparse won't bother anyone too much. > > Jonathan Thank you for all the feedback! I'll try to keep an eye on the lists in case of automatic reports. --=20 Thanks, ~ Kurt