From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DB462F6165 for ; Mon, 26 Jan 2026 08:30:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769416215; cv=none; b=DB1Pw+rYEnDKram7SyQiFfXGLIFWcxCPsvty46uF/aXQdQOTCZEQwS4iejLOhWAn8vRfai8JmjiQzWA3PpOXlPSRXb+Ta0752ADIJ+ui4BSdDKlUfUR8FIBhIWWaoaLy1RZpne7sxLdBv/fN3DGfBHF3VXWWbxp1kVrI6Oja6sE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769416215; c=relaxed/simple; bh=K0VZgvjYgXw2TwSd56awEP0HWtuv9A0xTzSkbJQtJ4w=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=VDBL1whcIojIuxgIDxRllr22q25garRQ2WDffrb/U9187zc1zzdx+/bQ+r61WQlg931ZLMS+BxjxhkukHdjZOsoWF8L/ZHz0CCYAKDYKyl1WLph93rIl2lNS+VuU3SwQZ5h03vMdBhsx2YXWMOgzWjqJxBii/XC6a/kOiyDD+Rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=om7p5rE3; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="om7p5rE3" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 30A161A2A4D; Mon, 26 Jan 2026 08:30:13 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0368160717; Mon, 26 Jan 2026 08:30:13 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B5AE2119A80E2; Mon, 26 Jan 2026 09:30:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769416212; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=RL12cC9qRX/ILoBDTmW2NvbjM3xBeSvvr6O9KVeZoZg=; b=om7p5rE3iiSwBy9bPPxolkQYErQW/3CDgztw9hO1NsSOzcCt3Au/qjDso2nw8w+QNQWbUk UkEzPTb9UlKqYKAvpL9GsVOaEJmKX2fEFmk+4Ee3r8C+8TIZEGPOtwQUjQCU5IUuIMxRJn z6LJUNbgR9DXE2ijEVLiBnIy0QbeaKf0++EC+uEC2SyurJMh42AV9e19mKvUjmD8jYiJu+ +Q+RIwCS/Ip57PyXQdLH/RRv5vnsFKJciIh9RqI4MJYsAnXAeMe5kl8E5oUOUyopCRJ0M4 /b2bLgC1Qg7JGb+y/8Fu4jrnUwmNHgxUTudw3edMKm+7ysEjJO71Xx6dKBOslg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 26 Jan 2026 09:30:09 +0100 Message-Id: Subject: Re: [PATCH 2/3] drm/bridge: imx8qxp-pxl2dpi: Fix NULL pointer dereference in imx8qxp_pxl2dpi_bridge_destroy() Cc: , , , To: "Liu Ying" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20260123-imx8qxp-drm-bridge-fixes-v1-0-8bb85ada5866@nxp.com> <20260123-imx8qxp-drm-bridge-fixes-v1-2-8bb85ada5866@nxp.com> In-Reply-To: <20260123-imx8qxp-drm-bridge-fixes-v1-2-8bb85ada5866@nxp.com> X-Last-TLS-Session-Version: TLSv1.3 On Fri Jan 23, 2026 at 10:22 AM CET, Liu Ying wrote: > Pointer bridge->driver_private in imx8qxp_pxl2dpi_bridge_destroy() > is NULL when imx8qxp_pxl2dpi_bridge_probe() returns error, because > the pointer is initialized only when imx8qxp_pxl2dpi_bridge_probe() > returns 0. The NULL pointer would be set to pointer p2d and then > NULL pointer p2d would be dereferenced. Fix this by returning early > from imx8qxp_pxl2dpi_bridge_destroy() if !p2d is true. > > Fixes: 900699ba830f ("drm/bridge: imx8qxp-pxl2dpi: get/put the companion = bridge") > Signed-off-by: Liu Ying Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com