From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Gary Guo" <gary@garyguo.net>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Yury Norov" <yury.norov@gmail.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"Dirk Behme" <dirk.behme@de.bosch.com>,
"Steven Price" <steven.price@arm.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] rust: io: add `register!` macro
Date: Mon, 26 Jan 2026 20:46:27 +0900 [thread overview]
Message-ID: <DFYHVFT3E1SH.3JFDRG481P2YA@nvidia.com> (raw)
In-Reply-To: <DFYCR05BIXCK.24C5YRIM7KK7Y@nvidia.com>
On Mon Jan 26, 2026 at 4:45 PM JST, Alexandre Courbot wrote:
> I also only noticed now the proposed reordering:
>
> minor_version: [3:0],
>
> I don't have a strong opinion on that, but fwiw SystemRDL seems to do
> something like
>
> field minor_version[3:0];
>
> If we agree to align on it the latter might be preferable?
I have tried implementing the alternative syntaxes, and I think this is
a case where the original one was more readable. The bit fields are
better aligned and easier to skim when they are put before the field
name.
I'll keep it for v3, but of course remain open to alternatives.
next prev parent reply other threads:[~2026-01-26 11:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 7:23 [PATCH v2 0/5] rust: add `register!` macro Alexandre Courbot
2026-01-21 7:23 ` [PATCH v2 1/5] rust: enable the `generic_arg_infer` feature Alexandre Courbot
2026-01-21 11:48 ` Gary Guo
2026-01-21 7:23 ` [PATCH v2 2/5] rust: num: add `shr` and `shl` methods to `Bounded` Alexandre Courbot
2026-01-21 14:12 ` Gary Guo
2026-01-26 3:23 ` Alexandre Courbot
2026-01-26 3:28 ` Miguel Ojeda
2026-01-21 17:49 ` kernel test robot
2026-01-21 7:23 ` [PATCH v2 3/5] rust: num: add `as_bool` method to `Bounded<_, 1>` Alexandre Courbot
2026-01-21 14:13 ` Gary Guo
2026-01-21 7:23 ` [PATCH v2 4/5] rust: io: add `register!` macro Alexandre Courbot
2026-01-21 13:13 ` Alexandre Courbot
2026-01-21 14:15 ` Gary Guo
2026-01-26 3:23 ` Alexandre Courbot
2026-01-21 14:50 ` Gary Guo
2026-01-21 16:15 ` Miguel Ojeda
2026-01-26 4:31 ` John Hubbard
2026-01-26 4:33 ` John Hubbard
2026-01-26 3:24 ` Alexandre Courbot
2026-01-26 6:57 ` Alexandre Courbot
2026-01-26 7:45 ` Alexandre Courbot
2026-01-26 11:46 ` Alexandre Courbot [this message]
2026-01-21 21:39 ` kernel test robot
2026-01-21 7:23 ` [PATCH FOR REFERENCE v2 5/5] gpu: nova-core: use the kernel " Alexandre Courbot
2026-01-21 9:16 ` [PATCH v2 0/5] rust: add " Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFYHVFT3E1SH.3JFDRG481P2YA@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dirk.behme@de.bosch.com \
--cc=ecourtney@nvidia.com \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox