From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Rachit Dhar" <rchtdhr@gmail.com>, "Viresh Kumar" <vireshk@kernel.org>
Cc: "Johan Hovold" <johan@kernel.org>,
"Alex Elder" <elder@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
<greybus-dev@lists.linaro.org>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] staging: greybus: resolved checkpatch checks for fw-management.c
Date: Mon, 02 Feb 2026 16:22:07 -0600 [thread overview]
Message-ID: <DG4TRYCISMJS.9GAR9YLQ0CNU@gmail.com> (raw)
In-Reply-To: <20260202202643.160199-1-rchtdhr@gmail.com>
On Mon Feb 2, 2026 at 2:26 PM CST, Rachit Dhar wrote:
> ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
> - intf_load.load_method, intf_load.firmware_tag);
> + intf_load.load_method,
> + intf_load.firmware_tag);
> if (ret)
> return ret;
>
This should be it's own style patch. Please keep one logical change per patch.
ET
prev parent reply other threads:[~2026-02-02 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 20:26 [PATCH 1/3] staging: greybus: resolved checkpatch checks for fw-management.c Rachit Dhar
2026-02-02 22:22 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG4TRYCISMJS.9GAR9YLQ0CNU@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rchtdhr@gmail.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox