* [PATCH 1/3] staging: greybus: resolved checkpatch checks for fw-management.c
@ 2026-02-02 20:26 Rachit Dhar
2026-02-02 22:22 ` Ethan Tidmore
0 siblings, 1 reply; 2+ messages in thread
From: Rachit Dhar @ 2026-02-02 20:26 UTC (permalink / raw)
To: Viresh Kumar
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev,
linux-staging, linux-kernel, Rachit Dhar
Resolved two checks highlighted by checkpatch.pl:
- added comment to mutex declaration
- fixed styling issue
Signed-off-by: Rachit Dhar <rchtdhr@gmail.com>
---
drivers/staging/greybus/fw-management.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c
index 152949c23d65..cf917ddb79c4 100644
--- a/drivers/staging/greybus/fw-management.c
+++ b/drivers/staging/greybus/fw-management.c
@@ -28,7 +28,7 @@ struct fw_mgmt {
/* Common id-map for interface and backend firmware requests */
struct ida id_map;
- struct mutex mutex;
+ struct mutex mutex; /* protects fw_mgmt->disabled, and serializes ioctl */
struct completion completion;
struct cdev cdev;
struct device *class_device;
@@ -434,7 +434,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd,
return -EFAULT;
ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
- intf_load.load_method, intf_load.firmware_tag);
+ intf_load.load_method,
+ intf_load.firmware_tag);
if (ret)
return ret;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] staging: greybus: resolved checkpatch checks for fw-management.c
2026-02-02 20:26 [PATCH 1/3] staging: greybus: resolved checkpatch checks for fw-management.c Rachit Dhar
@ 2026-02-02 22:22 ` Ethan Tidmore
0 siblings, 0 replies; 2+ messages in thread
From: Ethan Tidmore @ 2026-02-02 22:22 UTC (permalink / raw)
To: Rachit Dhar, Viresh Kumar
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev,
linux-staging, linux-kernel
On Mon Feb 2, 2026 at 2:26 PM CST, Rachit Dhar wrote:
> ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
> - intf_load.load_method, intf_load.firmware_tag);
> + intf_load.load_method,
> + intf_load.firmware_tag);
> if (ret)
> return ret;
>
This should be it's own style patch. Please keep one logical change per patch.
ET
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-02 22:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-02 20:26 [PATCH 1/3] staging: greybus: resolved checkpatch checks for fw-management.c Rachit Dhar
2026-02-02 22:22 ` Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox