From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f53.google.com (mail-yx1-f53.google.com [74.125.224.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7309434B1A5 for ; Mon, 2 Feb 2026 22:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770070945; cv=none; b=tddRLeHaYwOLV+A28/3a1m9+p5tEd7ME/qImexI1hmFZHNLxcHoMnZdcFgl07eZsiCrEuewc00n+wND39egpigIDrbh74HF5YgwFw3sppvfR/PiZ7c2K7OINeQoCsIDUOfT73iDTQoy0hTsyeqtBU2hRreBJeuxnhfdcwO6URCk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770070945; c=relaxed/simple; bh=O57yPyzJ8OkY1f4uJLZBuUTqVCcR6SJYJ+K13KBQke4=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=jO7QwNlyBZABQ/HzgMkqHjBVVPYh+8W2UVfOrH5kCyA6kmWvH6EAHzZx+C11dMedDMZSkKyx3G6+tON/nr9oqTp4gaKW5pXgTQUVoMTSrzLzzBLpMCBvrZ+LBlBucjyYKLxtw2X4hju7/OJt8Ar1Kp2LTX5SPWIrsoqG3mKOAvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AT6lkawo; arc=none smtp.client-ip=74.125.224.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AT6lkawo" Received: by mail-yx1-f53.google.com with SMTP id 956f58d0204a3-649bff225d4so1590268d50.2 for ; Mon, 02 Feb 2026 14:22:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770070942; x=1770675742; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=byuDbDXqsC+RTpprTwmnIg5GJlDhbXjIuCmiCm364zw=; b=AT6lkawoCK+pY58gTb8ooQ4sOQsWdHw3QggOyTPGYSbtRhcEgaq4cTAXEM1tym5VUx Bwq1uy6A1LMxUP1JRpyXdbddyTW2MNC2EpgTNzeRd2JXH9RgxDH4RCJjlo6VfahVacRs 1ny3zj7YviEU2t6jDGKowLJlw9bYhIo5I4Zi1l+Ls5x9Ol1D7jeoDhYuIRR72kXongZv jLDK9Sx7WdvpgRfuNZh3D5Il9ZbzSj80/2EbyllcWTcjRdvmeGbbF0n+Q30F2vABg+ZP SETo6sBa29Inf/94dD+/vwubDAuP9GrT/UwPvLGGwVP2Kg0QFIz6TeqIefXjJxj5EIlf 20/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770070942; x=1770675742; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=byuDbDXqsC+RTpprTwmnIg5GJlDhbXjIuCmiCm364zw=; b=dlptbFLMHX4Iy0Fol4DWN/da4ms8JeB51n7FBhhgQ9QuGRPaKeyYWJpY8aXxTsqBlp q2Fr90AeIUj7ZQWdBP5zdyYipxS2Wx9grEy8b1kOmDQ6EYaDoQ3LOXB1l1L8savjAByQ h7TVWr5Lnmjt3BEWpuJhPkKAeH1o7j+PIFVRetaIE4PPVlS8hLqJuw9je85JbdGeegbH cgeBiIz8pGWTcVeVe48EMOQt7kcXddHoyHWaJ/njTVkTU+XPdVW58Zg97Gbp53gTBLYX ZbGOqk1rAozrMKNVdKPFhd//PBS0utC+h0PzlRCLrVGCMyZXJKIgbpe7bbVn9EvL6b+T pgQw== X-Forwarded-Encrypted: i=1; AJvYcCXOQ5B8ei3lOb9JsQoF9ss6RchKBYNZBiblOsl2SF5OeyOI61/gsk7xFnJYxRrfUNiMiYgDsBI9UoRAP5o=@vger.kernel.org X-Gm-Message-State: AOJu0YyxixQjVJA18EvTL4ACtrDguMR/z9auXPcCv6gpEEyhyHIjrhYz HR0an0vxytU+Gy7zKfZcr72DozQkybXN/6ty+IZ+S/Mwp+J/zMkyEAO4 X-Gm-Gg: AZuq6aKZmdKoYtYXnh2kS0vuCB/87o3sRjEFRZUaeaBzQKZX/KnY4o8z+TnTKK5tBf/ wh1Yg6y/af5Pwn8Y52oniFZph0qCIg5juHr908xVTQCT+bb+o2z8qj2e1AkSpdC6C8NLMU3v+w4 8Xzu+uAru3df4LPloZvuKVsXzg7KIgf441+nGUzIw8Wu3ZhDFvwfLj62pph2RwiLmKvkNMlWlab PRtHBqZDqWZE8/IFy3pwWdfYZp7kAAQUthSmLxC/LmOfr/7rxWREMrIgnBxeM+gEAAOE67NBDp5 G+UzQky6mDblSAteLZ5u5Ms3nnolyRtIQ5p9HqCA+RNQwcX4gKeapmeAw/JmuutcYXTdxZLdUia FcMsqq6bnl8W6uh5K6k66fdNQFQUU7bB4iEhI0jkByVGWoUbJjFSq9jg7tl/iEaJcoE3ZqvZesM DDfBgfpfTftP2udRux3hgcAOQpxg3KkrQ= X-Received: by 2002:a53:ac99:0:b0:649:6b11:78eb with SMTP id 956f58d0204a3-649a84ed9famr10328451d50.68.1770070942309; Mon, 02 Feb 2026 14:22:22 -0800 (PST) Received: from localhost ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-649960642c6sm10280131d50.3.2026.02.02.14.22.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 14:22:22 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 02 Feb 2026 16:22:07 -0600 Message-Id: Cc: "Johan Hovold" , "Alex Elder" , "Greg Kroah-Hartman" , , , Subject: Re: [PATCH 1/3] staging: greybus: resolved checkpatch checks for fw-management.c From: "Ethan Tidmore" To: "Rachit Dhar" , "Viresh Kumar" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260202202643.160199-1-rchtdhr@gmail.com> In-Reply-To: <20260202202643.160199-1-rchtdhr@gmail.com> On Mon Feb 2, 2026 at 2:26 PM CST, Rachit Dhar wrote: > ret =3D fw_mgmt_load_and_validate_operation(fw_mgmt, > - intf_load.load_method, intf_load.firmware_tag); > + intf_load.load_method, > + intf_load.firmware_tag); > if (ret) > return ret; > =20 This should be it's own style patch. Please keep one logical change per pat= ch. ET