From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Matthew Maurer" <mmaurer@google.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Satya Durga Srinivasu Prabhala" <satyap@quicinc.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Michal Wilczynski" <m.wilczynski@samsung.com>,
"Dave Ertman" <david.m.ertman@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Trilok Soni" <tsoni@quicinc.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
rust-for-linux@vger.kernel.org, driver-core@lists.linux.dev,
dri-devel@lists.freedesktop.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH v2 6/6] soc: qcom: socinfo: Convert to Rust
Date: Tue, 03 Feb 2026 18:59:52 +0100 [thread overview]
Message-ID: <DG5ITP7I2CQO.DOQM3MZKKPS9@kernel.org> (raw)
In-Reply-To: <DG5HX5K2T371.3JGY5PQIV554K@garyguo.net>
On Tue Feb 3, 2026 at 6:17 PM CET, Gary Guo wrote:
> PS. Personally I think this check (and the one in Devres::access) should use
> assertion rather than `EINVAL`, because it is a bad driver bug when this is hit,
> and adding failing code path for something that is a bug is something I really
> dislike... It should at least be a `WARN`.
I don't think we should panic in this case, as it can happen too easily.
// Let's assume the resource is owned by the parent.
fn foo(adev: &auxiliary::Device<Bound>, res: &Devres<Resource>) {
let res = res.access(dev.parent()); // OK
let res = res.access(dev.as_ref()); // panic()
}
Printing a warning is probably a good idea though.
next prev parent reply other threads:[~2026-02-03 17:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 15:46 [PATCH v2 0/6] soc: qcom: socinfo: Convert to Rust Matthew Maurer
2026-02-03 15:46 ` [PATCH v2 1/6] rust: Add sparse_array! helper macro Matthew Maurer
2026-02-03 15:46 ` [PATCH v2 2/6] rust: io: Support copying arrays and slices Matthew Maurer
2026-02-03 15:53 ` Danilo Krummrich
2026-02-03 15:46 ` [PATCH v2 3/6] rust: device: Support testing devices for equality Matthew Maurer
2026-02-03 15:56 ` Danilo Krummrich
2026-02-03 16:05 ` Gary Guo
2026-02-03 16:15 ` Greg Kroah-Hartman
2026-02-03 16:17 ` Greg Kroah-Hartman
2026-02-03 16:29 ` Danilo Krummrich
2026-02-03 16:40 ` Greg Kroah-Hartman
2026-02-03 16:46 ` Danilo Krummrich
2026-02-03 17:17 ` Matthew Maurer
2026-02-03 15:46 ` [PATCH v2 4/6] rust: auxiliary: Support accessing raw aux pointer Matthew Maurer
2026-02-03 15:55 ` Danilo Krummrich
2026-02-03 15:46 ` [PATCH v2 5/6] rust: debugfs: Allow access to device in Devres-wrapped scopes Matthew Maurer
2026-02-03 15:59 ` Danilo Krummrich
2026-02-03 16:47 ` Gary Guo
2026-02-03 16:58 ` Danilo Krummrich
2026-02-03 18:04 ` Matthew Maurer
2026-02-03 15:46 ` [PATCH v2 6/6] soc: qcom: socinfo: Convert to Rust Matthew Maurer
2026-02-03 16:28 ` Greg Kroah-Hartman
2026-02-03 16:35 ` Danilo Krummrich
2026-02-03 16:48 ` Greg Kroah-Hartman
2026-02-03 16:56 ` Danilo Krummrich
2026-02-03 17:17 ` Gary Guo
2026-02-03 17:26 ` Matthew Maurer
2026-02-03 17:59 ` Danilo Krummrich [this message]
2026-02-03 17:37 ` Matthew Maurer
2026-02-04 8:38 ` Greg Kroah-Hartman
2026-02-03 20:27 ` Bjorn Andersson
2026-02-04 8:40 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG5ITP7I2CQO.DOQM3MZKKPS9@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=andersson@kernel.org \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=david.m.ertman@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=konradybcio@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=m.wilczynski@samsung.com \
--cc=mmaurer@google.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=satyap@quicinc.com \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tsoni@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox