From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: "Daniel Almeida" <daniel.almeida@collabora.com>,
"Link Mauve" <linkmauve@linkmauve.fr>,
rust-for-linux@vger.kernel.org,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Srinivas Kandagatla" <srini@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Eric Biggers" <ebiggers@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Lyude Paul" <lyude@redhat.com>,
"Asahi Lina" <lina+kernel@asahilina.net>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
officialTechflashYT@gmail.com, "Ash Logan" <ash@heyquark.com>,
"Roberto Van Eeden" <rw-r-r-0644@protonmail.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Subject: Re: [PATCH v2 1/4] rust: io: Add big-endian read and write functions
Date: Thu, 05 Feb 2026 23:43:48 +0100 [thread overview]
Message-ID: <DG7E46M9VINC.3KTNQ1T7USPVO@kernel.org> (raw)
In-Reply-To: <DG7DUN9M4YIU.KNRN6FM1K687@garyguo.net>
On Thu Feb 5, 2026 at 11:31 PM CET, Gary Guo wrote:
> On Thu Feb 5, 2026 at 7:05 PM GMT, Danilo Krummrich wrote:
>> (1) Devices are either little-endian or big-endian. Hence, having to write
>>
>> io.big_endian().write()
>>
>> is excessive, we always want big-endian for a big-endian device.
>
> You don't need to always write this. You just need to do `big_endian()` once
> when you obtain the io, and then keep using `BigEndian<Mmio>` instead of just
> `Mmio`, and the rest of code is still `.write()`.
<snip>
>> (2) It is error prone, if you forget to call big_endian() first, it is a bug.
>
> Moot point when `big_endian()` is only done once.
Well, you need to do it at least once per driver entry point. For DRM IOCTLs for
instance you also have to consider that it is always Devres<Mmio>.
next prev parent reply other threads:[~2026-02-05 22:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 4:04 [PATCH v2 0/4] Add Rust abstractions for nvmem-provider Link Mauve
2026-02-04 4:04 ` [PATCH v2 1/4] rust: io: Add big-endian read and write functions Link Mauve
2026-02-04 15:18 ` Danilo Krummrich
2026-02-04 15:20 ` Danilo Krummrich
2026-02-05 14:28 ` Daniel Almeida
2026-02-05 14:56 ` Danilo Krummrich
2026-02-05 15:16 ` Gary Guo
2026-02-05 17:28 ` Daniel Almeida
2026-02-05 19:05 ` Danilo Krummrich
2026-02-05 21:20 ` Link Mauve
2026-02-05 22:11 ` Danilo Krummrich
2026-02-05 22:31 ` Gary Guo
2026-02-05 22:43 ` Danilo Krummrich [this message]
2026-02-08 17:17 ` Daniel Almeida
2026-02-08 17:52 ` Danilo Krummrich
2026-02-05 22:46 ` Danilo Krummrich
2026-02-04 4:04 ` [PATCH v2 2/4] rust: nvmem: Add an abstraction for nvmem providers Link Mauve
2026-02-04 15:22 ` Danilo Krummrich
2026-02-05 12:48 ` Link Mauve
2026-02-05 12:57 ` Danilo Krummrich
2026-02-04 4:05 ` [PATCH v2 3/4] nvmem: Replace the Wii and Wii U OTP driver with a Rust one Link Mauve
2026-03-04 18:46 ` Link Mauve
2026-02-04 4:05 ` [PATCH v2 4/4] powerpc: wii_defconfig: Enable Rust Link Mauve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG7E46M9VINC.3KTNQ1T7USPVO@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=ardb@kernel.org \
--cc=ash@heyquark.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=chleroy@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=ebiggers@google.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=j.neuschaefer@gmx.net \
--cc=lina+kernel@asahilina.net \
--cc=linkmauve@linkmauve.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=maddy@linux.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=officialTechflashYT@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=rw-r-r-0644@protonmail.com \
--cc=srini@kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox