From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91E17315D30 for ; Sat, 7 Feb 2026 01:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770428405; cv=none; b=dr7Csk33sGYCazjJNX0FJXqsqiHfgJGdzztgJl024c7aYhwrn2S0n/jFayhfw6XZXIJJEAU9so40stakM92uoE4mQ6krkEOXwLjwR/cmRIfZK1VDcTl6wZY9V357rA6wPdh1bGRrQysAc8Tlkf1LxBftZMM0usz7E1JwrkzI6BU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770428405; c=relaxed/simple; bh=M62afnOjhdKd2LSJmpCe4t3odjQlhnPvpxSTbSqb0cQ=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=ZgLSMjaYggayBOF9Gib1oItta4taF6Vw9pwMPtqC9OT4fiqcQp5tdMDchluSASxvEBSCWpDsToTc2fa4ZZ1RYZRl8SeIONHUOm7CRUV/1zUAgl6IP/Rrbn9++n3LqtNiUz/UHuXiwHIQzb25ahDMhfiM1xMi3vzw2lKfOrSBb/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SO9W7yfl; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SO9W7yfl" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7d18dd2adf7so1610104a34.1 for ; Fri, 06 Feb 2026 17:40:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770428404; x=1771033204; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M62afnOjhdKd2LSJmpCe4t3odjQlhnPvpxSTbSqb0cQ=; b=SO9W7yfl7qhcuScYesAbEcpxGN9R/l/MmkO4VDoKtBCsOBqpIoZZfo3Ci0y54vo4cp 5ZPgWPG99X8shXr9IQUBo0DQiEohdWmowrT6bYy7+vDKbIZzxHexmlDnX97XrTvHOUtn IWXgwyUr/ePjbbA946ZBeoRx1xCTKcgC0JvGKf0WjDJnrLbK4ZTjiDolgha1gvbDncdz f10BjuhQ1CYbDP1D4jKF1uSpJcH21/RtWcqMeXRaxakniEgzP60uehN6tdIo4nr1Mbg6 XvSoJ/H/y3hBnW+3szCC+ZUrw5ha41/KWbE33LTVhMIeZURryTMOfhbkK89IJfX0QZZK wv6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770428404; x=1771033204; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=M62afnOjhdKd2LSJmpCe4t3odjQlhnPvpxSTbSqb0cQ=; b=kgaCkW+yQWi6Bs7xEQA3LbRAm+02zN86uipvADqHpYz4U+hvf/ByYOZNjX2w+I0IUJ qqrO2rV3orKvmQBDIVdc6cxeYfeKmBACCPz81ViVGjVAoacQmFa/GdeKCLyhEDrTI8HO ub6P2QXXLcUm3/ScGZQsmRnAo7iVOgYUQfxSieiyxFAmVhze00xHZSIFVJsS4Gxj2RCQ /KPxHTngb2EWimAZCFe6lJVsT0ZbeaAMOF1DCXBMw4jwj5Fsca5o7UT6h4ryUK8i9zvU hdSxhF5rMiBmAcJo9e8uRxMFn+kdUP/BUmCVjp+e8RxNt6oKoDh3XLRVYtk/jNap4cJM 5kcg== X-Forwarded-Encrypted: i=1; AJvYcCVWSF7mV4kLMMjqlRrum9daqkqPPMMUcwXUfrXtLbpXf5jE97W/tmTR7mz1vPKCVlds8UXLsp3SnCcQ6v4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp6L3qnqI/gFov6NMb6XakcoYwaaGRtTkMGnlLjU+z3hz19RYo 7I9pJVQ8foRliuafcXGXs/wSKsp6xkUahloDMH+GmMkhUwtmt4icEXcy X-Gm-Gg: AZuq6aK6vj6rKgwYuMKeWJQ66Ckw/VhavAPFgV66dIuNdWHZb4Cz3zE6K5Qv/FR+vDy Gk2q3g/I75ANdBVq0/6RrdIHC2Fr1Gfr7eCAaFEx6os6Igbr3TglpQinO3w6bBv9q5aXHpvk9gi tZXWLfDpmQF0fagI09lWYI7m6aDZtu+y2fy8ZiVXuMURhTXSLcLouo6FjnP3bt5bpMlyYJ7Mb57 YbSOjl5p/s1xTVHDp2lmPbU9B2iyGmgJA4pgBhl4Z53Rufb8f3UwuBRmbYDZHIDY3MiBbK9NRbx 5F8d03nKRdw7R3agq+c9xoSZRgGNABtRU4cTpouHKLZD5kkLk7a/7mnxDMs8hoqNLKKJAdWD3nw P6S7oNy6YFldm0J8uTHK60dhMyhI8TWF/IWwpG65E+X389kNbiZywY4A7zuKwONQoVqrxdMV9bS qJJ5vS1rbLb9NDPHo6EGq95uHUEYkrNge3K/FCqZJgP35O2hMUoC50OmnJbblm67uhO9rdfMqu3 Ex4ARwxkIXWwz7Lic+TL6cqhw6rJI+11l1Yql8JFrXHJ0UxAZbyQ3JE/g== X-Received: by 2002:a05:6830:82e6:b0:7c6:cf19:1df1 with SMTP id 46e09a7af769-7d4646a15admr2050206a34.30.1770428404415; Fri, 06 Feb 2026 17:40:04 -0800 (PST) Received: from localhost ([2600:100d:b16d:c41f:8cad:1966:30a2:c669]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d46479964fsm2725883a34.22.2026.02.06.17.40.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Feb 2026 17:40:04 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 06 Feb 2026 19:40:02 -0600 Message-Id: Cc: "Dan Carpenter" , "Ethan Tidmore" , , Subject: Re: [PATCH] [PATCH] staging-next: most: dim2: convert pr_info/err/warn to dev_info/err/warn From: "Ethan Tidmore" To: "Zeeshan Ahmad" , "Parthiban Veerasooran" , "Christian Gromm" , "Greg Kroah-Hartman" X-Mailer: aerc 0.21.0 References: <20260206233501.5682-1-zeeshanahmad022019@gmail.com> In-Reply-To: <20260206233501.5682-1-zeeshanahmad022019@gmail.com> On Fri Feb 6, 2026 at 5:35 PM CST, Zeeshan Ahmad wrote: > Note: This is a re-submission of a previous patch sent with an incorrect = CC. > Please consider this the correct submission. This line is over 75 characters which breaks linux kernel coding style. Use "$ ./scripts/checkpatch.pl --strict " from now on before sending your patch off to catch things like this. Also, this note belongs in your v2 changes below the "---". > > The dim2 driver currently uses generic pr_* logging macros. Hardware > drivers should use the device-specific dev_* logging macros to provide > better context in the system logs, especially in systems with multiple > controller instances. > > This patch converts all applicable logging calls in dim2.c to use the > proper device-specific APIs. > > Note: This patch is rebased on the current staging-next branch. > It was previously submitted against master. This should also be below the "---" in v2 changes. > > Signed-off-by: Zeeshan Ahmad > --- Your header begins with "[PATCH] [PATCH]" [PATCH] should only happen once and since it appears this is your v2 it should have been [PATCH v2]. Also, you used "staging-next:" I guess you were using the branch name but, the correct way to do it is just "staging:". Please visit Dan Carpenter's guide on submitting a v2: (but this next one will be your v3) https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ Thanks, ET